Remove unnecessary addition of 0.0f in vector addition#410
Open
Codebruh-sudo wants to merge 1 commit intoNVIDIA:masterfrom
Open
Remove unnecessary addition of 0.0f in vector addition#410Codebruh-sudo wants to merge 1 commit intoNVIDIA:masterfrom
Codebruh-sudo wants to merge 1 commit intoNVIDIA:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was going through the vectorAdd sample when I noticed
the kernel computes A[i] + B[i] + 0.0f.
Adding 0.0f has no effect on the result and looks . unintentional . possibly a leftover from an earlier
edit. Removing it keeps the code clean since this .sample is widely read as a teaching reference.and the result of kernel should be identical before and after change.