unify the storage of intermediate results#2069
Merged
ericniebler merged 1 commit intoNVIDIA:mainfrom May 6, 2026
Merged
Conversation
ericniebler
force-pushed
the
unify-storage-of-intermediate-results
branch
from
010afa4 to
5359b7c
Compare
ispeters
reviewed
May 6, 2026
| }; | ||
|
|
||
| // Add storage for an exception_ptr if the result datums are not all nothrow | ||
| // decay-copyable. |
Contributor
There was a problem hiding this comment.
Why build the decay-copy into this utility? Robert has an analogous facility that stores references where this facility would transform references into decay-copied values. Could you layer the decay-copy on top?
Collaborator
Author
There was a problem hiding this comment.
I don't know where I would use a storage type that stores references. None of the algorithms are specified to do that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
many async operations need to store the results of a child operation and send the results to a receiver later. in many places we are computing the type of a
__variantof__tuples for holding these results, and then using a visitor to send the results. it's a lot of code repetition.unify all of that into a
__results_storage<Signatures...>type that has a.__complete(receiver)member function that encapsulates the visitation.