linuxPackages.isgx: mark as broken for kernels >= 6.4#353876
Merged
wegank merged 1 commit intoNixOS:masterfrom Nov 9, 2024
Merged
linuxPackages.isgx: mark as broken for kernels >= 6.4#353876wegank merged 1 commit intoNixOS:masterfrom
wegank merged 1 commit intoNixOS:masterfrom
Conversation
Member
|
ZHF: #352882 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the common failures in the kernel package sets is the out-of-tree
isgxmodule (upstream repository here). The maintainers note:There are some old, unmerged PRs to bring the module compatability to recent kernels but it largely seems like Intel has officially deprecated the out of tree module.
I ran a few builds against the versioned kernel package sets for the module and it won't succeed on anything up to or past 6.4, so this PR should properly highlight when the module won't work as expected.
Maybe Intel will merge fixes for recent kernels and the bounds on the
brokenattribute can be updated, but for the time being, this change should accurately reflect when the module will and won't work.(NB I'm treading into kernel sets for the first time so feel free to correct anything I'm doing wrong here)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.