Skip to content

linuxPackages.isgx: mark as broken for kernels >= 6.4#353876

Merged
wegank merged 1 commit intoNixOS:masterfrom
tylerjl:tylerjl/isgx-deprecated
Nov 9, 2024
Merged

linuxPackages.isgx: mark as broken for kernels >= 6.4#353876
wegank merged 1 commit intoNixOS:masterfrom
tylerjl:tylerjl/isgx-deprecated

Conversation

@tylerjl
Copy link
Copy Markdown
Contributor

@tylerjl tylerjl commented Nov 5, 2024

One of the common failures in the kernel package sets is the out-of-tree isgx module (upstream repository here). The maintainers note:

This driver is deprecated and no longer maintained by Intel. We recommend the SGX community to use the SGX driver that was upstreamed into the Linux kernel.

There are some old, unmerged PRs to bring the module compatability to recent kernels but it largely seems like Intel has officially deprecated the out of tree module.

I ran a few builds against the versioned kernel package sets for the module and it won't succeed on anything up to or past 6.4, so this PR should properly highlight when the module won't work as expected.

Maybe Intel will merge fixes for recent kernels and the bounds on the broken attribute can be updated, but for the time being, this change should accurately reflect when the module will and won't work.

(NB I'm treading into kernel sets for the first time so feel free to correct anything I'm doing wrong here)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 6, 2024
@Bot-wxt1221 Bot-wxt1221 added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 8, 2024
@Bot-wxt1221
Copy link
Copy Markdown
Member

ZHF: #352882

@wegank wegank merged commit 8cccca1 into NixOS:master Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants