Update display value whenever the data prop changes.#4
Open
JSONRice wants to merge 2 commits intoNovsochetra:mainfrom
Open
Update display value whenever the data prop changes.#4JSONRice wants to merge 2 commits intoNovsochetra:mainfrom
JSONRice wants to merge 2 commits intoNovsochetra:mainfrom
Conversation
Signed-off-by: jasonwr <jsnrice@gmail.com>
Author
|
@Novsochetra please oh please oh please oh please review and merge. Thank you. 🙏 I really want to use your software but really need this bug resolved. Thank you. |
Owner
|
@Jasonwr thank for pointing out this section. I will check this PR and merged for the next release. Thank you 😉😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title suggests this pull request addresses the data updates changing the display value since the displayValue is set to an initial value of
data[0]This line:
const [displayValue, setDisplayValue] = useState<DonutItem>(data[0]);Only get initialized once and never updates so a
useEffectis a workaround.