Merged
Conversation
Member
Author
|
/ocabot migration mrp |
Member
Author
|
/ocabot migration mrp_account |
| # DONE: see mrp.production#production_group_id | ||
|
|
||
| mrp / mrp.routing.workcenter / cost_mode (selection) : NEW selection_keys: ['actual', 'estimated'], hasdefault: default | ||
| mrp / mrp.routing.workcenter / note (html) : DEL |
Contributor
There was a problem hiding this comment.
why not save this field (with copy)?
Member
Author
There was a problem hiding this comment.
why save that one as opposed to any of the others? in my opinion, we copy columns when we modify them in a potentially lossy way, but leave all the others alone, no?
Contributor
There was a problem hiding this comment.
Yes. It's just that note seems to be a column one may want to save, it can have relevant content.
openupgrade_scripts/scripts/mrp/19.0.2.0/upgrade_analysis_work.txt
Outdated
Show resolved
Hide resolved
MiquelRForgeFlow
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.