Open
Conversation
Member
Author
|
/ocabot migration hr |
Comment on lines
+384
to
+385
| DEL res.groups: hr_contract.group_hr_contract_employee_manager (noupdate) | ||
| DEL res.groups: hr_contract.group_hr_contract_manager (noupdate) |
Contributor
There was a problem hiding this comment.
safely remove xmlid in post-migration, they are noupdate
Comment on lines
+104
to
+107
| openupgrade.load_data(env, "hr", "19.0.1.1/noupdate_changes.xml") | ||
| fill_hr_version(env) | ||
| hr_employee_bank_account_ids(env) | ||
| openupgrade.delete_records_safely_by_xml_id(env, _deleted_xmlids) |
Contributor
There was a problem hiding this comment.
Suggested change
| openupgrade.load_data(env, "hr", "19.0.1.1/noupdate_changes.xml") | |
| fill_hr_version(env) | |
| hr_employee_bank_account_ids(env) | |
| openupgrade.delete_records_safely_by_xml_id(env, _deleted_xmlids) | |
| fill_hr_version(env) | |
| hr_employee_bank_account_ids(env) | |
| openupgrade.load_data(env, "hr", "19.0.1.1/noupdate_changes.xml") | |
| openupgrade.delete_records_safely_by_xml_id(env, _deleted_xmlids) |
|
|
||
| # NOTHING TO DO | ||
|
|
||
| hr / hr.version / additional_note (text) : NEW |
Contributor
There was a problem hiding this comment.
fill from both hr_employee.notes and hr_contract.notes
| hr_version.employee_id=hr_employee.id | ||
| """ | ||
| ) | ||
| env.cr.execute( |
Contributor
There was a problem hiding this comment.
Add here an if clause to check whether hr_contract was installed or not. The insert query below is only for the case where hr_contract was not installed.
So, you need to add later, and else clause, and put another insert query for the case where hr_contract was installed.
The problem is: get_legacy_name("contract_id") cannot be both filled with id from hr_contract and hr_employee.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.