[18.0][MIG] base_dav: standard migrate by tendil · Pull Request #431 · OCA/server-backend

tendil · 2026-03-06T17:13:56Z

Standard migration from 11.0

cvinh · 2026-03-14T20:34:41Z

Hello,
Thanks for the veeeery welcomed migration !!!
I will review asap.
Do you think that we have any risk to send hundreds of meeting invitations at first sync ? (I remember bad memories about upgrading calendar...)
Best regards

Sign in to view

+    "summary": "Access Odoo data as calendar or address book",
+    "website": "https://github.com/OCA/server-backend",
+    "depends": [
+        "base",


Sign in to view

+            if value is None or value is False:
+                continue
+            if isinstance(value, bool):
+                continue


cvinh · 2026-03-15T00:21:40Z

+1.  Go to Settings / WebDAV Collections and create or edit your
+    collections. There, you'll also see the URL to point your clients
+    to.
+


It would be cool to :

add examples for mapping fields

recommend using an API Key instead of the user password in the client

add domain example (for example for personal calendar)

It would be cool to :

add examples for mapping fields

recommend using an API Key instead of the user password in the client

add domain example (for example for personal calendar)

@cvinh Good point, bit I'm not sure that these are the tasks we should do during module migration,
I suggest we create a new PR with revised documentation when we merge this PR.

sounds great

cvinh · 2026-03-15T01:12:24Z

+        :rtype: odoo.models.BaseModel
+        """
+        self.ensure_one()
+        return self.env[self.model_id.model].search(self._eval_domain())


I have access rights problems when trying to call self.model_id (cannot read ir_model)...
Is the solution to use sudo() ?

Suggested change

return self.env[self.model_id.model].search(self._eval_domain())

return self.env[self.sudo().model_id.model].search(self._eval_domain())

It happens also with self.field_uuid and self.field_id

Thank you!
I've applied it everywhere needed

hbrunn

thank you, this looks very good on first sight.

In v18, you can reasonably test this against the caldav lib in a HttpCase, so please do so

hbrunn · 2026-03-16T04:07:02Z

+  for every project and appointments are tasks, or a calendar for every
+  sales team and appointments are sale orders. Lots of possibilities.
+
+Backporting this to \<=v10 will be tricky because radicale only supports


I don't think we need this any more

hbrunn · 2026-03-16T04:10:08Z

+        :return: Access mode:
+                 - "rw" for read/write
+                 - "r" for read-only
+                 - "" for no access


please document values RW

hbrunn · 2026-03-16T04:14:16Z

+        if key == "C:supported-calendar-component-set":
+            return "VTODO,VEVENT,VJOURNAL"
+        if key == "ICAL:calendar-color":
+            return "#48c9f4"


the TODO here is still valid I think

hbrunn · 2026-03-16T04:18:44Z

@@ -1,2 +0,0 @@
-* Odoo Community Association: `Icon <https://github.com/OCA/maintainer-tools/blob/master/template/module/static/description/icon.svg>`_
-* All the actual work is done by `Radicale <https://radicale.org>`_


I don't think this should go away

Thanks for the feedback!
i deleted this file because I followed the migration documentation: https://arc.net/l/quote/bxjruewp

if you'd like it restored, just let me know and I'll revert it to its original state

this is about sentences like "migration to version 42 financially supported by acme ltd", but here we refer to the project that does all of the heavy lifting, so you can just keep the file minus the icon because we don't mention this explicitly any more

ikus060 · 2026-03-16T15:06:59Z

Hi @tendil

Thanks a lot for this PR. It comes at a very good timing for me, but it lacks some features I'm counting on. So base on your work, I started filling the gap:

Add support for built-in mapper for common use-case: address book mapping & calendar mapping.
Allow built-in mapping to be customized.
Mapping of calendar recursive event.

It might be a good idea to align each other work, as this work is in progress.

I'm also looking at improving some area like etag computation and sync-token which currently required the collection to be recomputed every time.

Here is my branch if you want to have a look: https://github.com/ikus060/server-backend/tree/base_dav-built-in-mapper

hbrunn · 2026-03-16T15:34:51Z

@ikus060 this module is called base_dav, whatever you do with specific odoo models belongs into an addon depending on this one, and probably into another repository.

It will be helpful if you review the migration as is with possibly an eye on extensibility to allow you doing what you want to do

ikus060 · 2026-03-16T15:42:04Z

@hbrunn Thanks for your feedback.

this module is called base_dav, whatever you do with specific odoo models belongs into an addon depending on this one, and probably into another repository.

Yes, I intend to split my changes into multiple modules in the future. But as I develop it's easier for me to place everything into the same module for now.

It will be helpful if you review the migration as is with possibly an eye on extensibility to allow you doing what you want to do

The current state is good enough for me. I will submit a new PR when I'm ready.

cvinh · 2026-03-16T18:31:32Z

Add support for built-in mapper for common use-case: address book mapping & calendar mapping.

Allow built-in mapping to be customized.

Mapping of calendar recursive event.

Hi @ikus060
You might be interested in OCA/calendar#209
Best regards

cvinh · 2026-03-16T18:49:23Z

+    ],
+    "external_dependencies": {
+        "python": ["radicale"],
+    },


Missing
"installable" : True,
"application": False,
...?

i didn't specify them on purpose because these are the default values - https://arc.net/l/quote/rentkjyl

tendil · 2026-03-17T09:19:35Z

Hello, Thanks for the veeeery welcomed migration !!! I will review asap. Do you think that we have any risk to send hundreds of meeting invitations at first sync ? (I remember bad memories about upgrading calendar...) Best regards

Thanks!

about the "hundreds of invitations" risk: the DAV proxy itself doesn’t send emails - it only forwards CalDAV/CardDAV requests to odoo create/write
to be 100% safe on the first sync, I suggest disabling outgoing mail servers

cvinh · 2026-03-19T02:39:15Z

LGTM please squash commits and I'll approve

tendil · 2026-03-20T08:15:10Z

LGTM please squash commits and I'll approve

I did it

hbrunn

on second look, this has some coding assistant smell so i have to switch into bullshit detection mode for review, which is quite taxing. did a couple of files, more to come after followup (please make your own BS removal pass first)

hbrunn · 2026-03-21T07:39:30Z

+            {
+                "auth": {"type": "odoo.addons.base_dav.radicale.auth"},
+                "storage": {"type": "odoo.addons.base_dav.radicale.collection"},
+                "rights": {"type": "odoo.addons.base_dav.radicale.rights"},
+                "web": {"type": "none"},
+                "hook": {"type": "none"},
+            },


take this from a function on self to make it simple to override. it would be perfect if those classes would be AbstractModels, but I don't see a simple way to do that

hbrunn · 2026-03-21T07:41:26Z

+
+        app = Application(configuration)
+
+        # Let's take WSGI environ from werkzeug/odoo


i find those llm-smelling comments somewhat jarring

hbrunn · 2026-03-21T07:42:24Z

+        if method == "PROPFIND" and len(raw_body) == 0:
+            raw_body = (
+                b'<?xml version="1.0" encoding="utf-8"?>'
+                b'<D:propfind xmlns:D="DAV:"><D:allprop/></D:propfind>'
+            )


why do we need this? shouldn't radicale handle that? if we need it, it needs a comment why

hbrunn · 2026-03-21T07:52:20Z

+
+        # Force Radicale to read the body we provide
+        environ["wsgi.input"] = io.BytesIO(raw_body)
+        environ["CONTENT_LENGTH"] = str(len(raw_body))


why do you need to set this? should exist already

wsgi.input is still set explicitly because radicale reads request bodies
from that wsgi key while in this odoo controller bridge it is not exposed in a usable form

if there's a better solution I'd appreciate any suggestions!

do nothing and keep whatever content length the client has sent

hbrunn · 2026-03-21T07:58:53Z

+            )
+
+        # Force Radicale to read the body we provide
+        environ["wsgi.input"] = io.BytesIO(raw_body)


why not

Suggested change

environ["wsgi.input"] = io.BytesIO(raw_body)

environ["wsgi.input"] = request.httprequest._HTTPRequest__wrapped.stream

request.httprequest.stream is not exposed publicly here

rebuilding wsgi.input from get_data() gives radicale a plain readable stream with a matching CONTENT_LENGTH, independent of how odoo wraps the underlying werkzeug request

this is also the variant i verified locally while request.httprequest.stream is not exposed here

as soon as this module fully supports files it will be needed because then we absolutely don't want to copy a potentially large upload here. will not press the point for now

hbrunn · 2026-03-21T08:09:44Z

+_logger = logging.getLogger(__name__)
+
+
+def load(configuration):


where is this being used?

thank you! confirmed: these module-level load() helpers are unused with the current radicale plugin loading flow

radicale loads the configured plugin module and instantiates the expected backend class directly, so these functions were dead code and have been removed

hbrunn · 2026-03-21T08:10:36Z

+    return env
+
+
+def _set_request_user(base_env, uid):


please avoid one line functions that are being used once and obfuscate stuff that's very standard Odoo

agreed, thank you!

hbrunn · 2026-03-21T08:15:29Z

+        }
+
+        try:
+            res = base_env["res.users"]._login(


going through login for every request slows down stuff considerably. i think it will be better to require apikeys and just do base_env['res.users.apikeys']._check_credentials. then you also don't need the synthesized user agent stuff.

also base_env is an odd name for a variable for an Odoo environment, that canonical name is env

switched dav auth to _check_credentials()

i also keep validating that the resolved user login matches the basic auth login

hbrunn · 2026-03-21T08:18:21Z

+            return ""
+
+        _set_request_user(base_env, uid)
+        return request.env["res.users"].sudo().browse(uid).login or login


the or login fallback is nonsense, remove

ikus060 · 2026-03-21T11:33:46Z

+            vobj.add(mapping.name).value = value
+
+        if "uid" not in vobj.contents:
+            vobj.add("uid").value = f"{record._name},{record.id}"


I don't understand the logic to generate a UID as <model_name>,<id>. This is not symmetric with implementation found in def get_record() where we simply expect an "id".

So the right implementation here is to use id has the uid by default.

In addition, if the collection has a field_uuid, The mapper should use that too.

So the right implementation should read:

if "uid" not in vobj.contents: vobj.add("uid").value = ( record[collection.field_uuid.name] if collection.field_uuid else str(record.id) )

agreed, thank you!
i changed the default uid generation to use the same identifier as the collection lookup

ikus060 · 2026-03-21T11:38:15Z

+
+        # created_item.href can differ from requested href (Odoo assigns new id)
+        vobj = created_item.vobject_item
+        uid_value = ""


All of the following lines is non-sens too me.

vobj should be a vcalendar. We can directly get the uid using:

uid_value = vobj.contents['vevent'][0].uid

agreed! i simplified the uid extraction accordingly

ikus060 · 2026-03-28T15:50:32Z

+        }
+
+        if self._record.tag == "VCALENDAR":
+            metadata["C:supported-calendar-component-set"] = "VTODO,VEVENT,VJOURNAL"


I don't think it makes any send to have a collection that return VTODO and VEVENT.

As we would map either calendar event OR tasks.

What is the use case we are trying to covert here ?

I would recommand to change a bit the implementation so each collection return either VEVENT, VTODO, VJOURNAL or VCARD, etc.

Take note VJOURNAL is not really supported by anything.

it no longer advertises mixed component support, so the collection is not misleading anymore and now exposes only VEVENT, which matches the current implementation

support other component types would require separate collection semantics and should be handled in a dedicated follow-up task

ikus060 · 2026-04-06T11:27:07Z

+        """
+        configuration = radicale_config.load()
+        configuration.update(self._get_radicale_config(), "odoo")
+        app = Application(configuration)


@tendil I'm not sure this implementation is optimal. The application get re-created on every request. I think it should be turned into a single. What do you think ?

agreed
i changed it to a lazily cached app instance at module level, so it is created once per odoo worker process instead of once per request

i used a module-level cache instead of controller state to keep the lifecycle explicit and make it easy to reset in tests

@tendil Thanks for the update. I will test it soon.

I'm poking around because I'm currently working to implement CalDAV for calendar events on top of your work. 😄

diggy128 · 2026-04-20T23:07:14Z

Any update on this?

Co-authored-by: Yannick Vaucher <yannick.vaucher@camptocamp.com>

Task: 5250

tendil · 2026-04-21T09:42:55Z

Any update on this?

yes, the pr is ready for review; you can take a look

however, after the rebase, there are issues with the tests in the base_external_system module
we are investigating the cause

Radicale re-registers logging level 25 as NOTICE during module import. Odoo uses the same numeric level for RUNBOT logs and expects it to be displayed as INFO. Because of this conflict, the standard "modules loaded..." log line is emitted as NOTICE and OCA checklog fails the pipeline even though tests pass. Restore the odoo mapping for RUNBOT after base_dav imports so level 25 is displayed as INFO again. Task: 5250

tendil · 2026-04-24T14:31:43Z

@hbrunn, i would really appreciate it if you could review the code again!

the test pipeline has been fixed

This was referenced Mar 6, 2026

base_dav dead? #254

Closed

[MIG] base_dav: Migration to 17.0 #269

Closed

[MIG] base_dav: Migration to 17.0 #276

Draft

tendil force-pushed the 18.0-t5250-base_dav-standard_migrate branch 2 times, most recently from 6d0d5a1 to 6457675 Compare March 13, 2026 20:26

cvinh mentioned this pull request Mar 14, 2026

[18.0][MIG] calendar dav: Migration to 18.0 OCA/calendar#205

Open

cvinh suggested changes Mar 15, 2026

View reviewed changes

cvinh reviewed Mar 15, 2026

View reviewed changes

This was referenced Mar 16, 2026

[18.0][FIX] base dav: fixes update from client to server with calendar #433

Open

[18.0][IMP] base_dev: add support for html fields #434

Open

hbrunn requested changes Mar 16, 2026

View reviewed changes

This was referenced Mar 16, 2026

[18.0][IMP] base_dav: add support to lists and lists of dicts #435

Open

[18.0][IMP] base_dav: add re support to export_code mapping #436

Open

[18.0][IMP] calendar_dav : add support to accept invitation from the phone OCA/calendar#207

Open

cvinh reviewed Mar 16, 2026

View reviewed changes

tendil requested review from cvinh and hbrunn March 17, 2026 10:43

tendil force-pushed the 18.0-t5250-base_dav-standard_migrate branch from 973fc83 to a902e02 Compare March 20, 2026 08:11

cvinh approved these changes Mar 20, 2026

View reviewed changes

hbrunn requested changes Mar 21, 2026

View reviewed changes

ikus060 reviewed Mar 21, 2026

View reviewed changes

ikus060 reviewed Mar 28, 2026

View reviewed changes

tendil force-pushed the 18.0-t5250-base_dav-standard_migrate branch 2 times, most recently from 9b6a760 to bed8559 Compare March 30, 2026 20:42

tendil requested review from hbrunn and ikus060 March 30, 2026 20:44

ikus060 reviewed Apr 6, 2026

View reviewed changes

tendil requested a review from ikus060 April 6, 2026 13:21

hbrunn and others added 12 commits April 21, 2026 08:20

[ADD] base_dav

e762095

Fix CI errors

bed6264

Mute radicale logger for testing

0028800

Use the collection as first argument in the creation of the items

1d280f3

Use related model_id field to build domain

5812846

Set default id for fields

ea33b07

Co-authored-by: Yannick Vaucher <yannick.vaucher@camptocamp.com>

Add missing quotation

06a47c4

[MIG] base_dav: Migration to 18.0

f32d3f3

Task: 5250

[FIX] base_dav: resolve comments

a806fd7

Task: 5250

[FIX] base_dav: add radicale version in requirements

4f99229

Task: 5250

[FIX] base_dav: resolve comments

462f41c

Task: 5250

[FIX] base_dav: resolve comments

14f10be

Task: 5250

tendil force-pushed the 18.0-t5250-base_dav-standard_migrate branch from 6e6d5f2 to 14f10be Compare April 21, 2026 08:23

OCA-git-bot added series:18.0 mod:base_dav Module base_dav labels Apr 21, 2026

tendil force-pushed the 18.0-t5250-base_dav-standard_migrate branch from e17c6e7 to 14f10be Compare April 22, 2026 20:23

OCA-git-bot added the mod:base_external_system Module base_external_system label Apr 22, 2026

tendil force-pushed the 18.0-t5250-base_dav-standard_migrate branch from 02aa0f5 to ec62a45 Compare April 24, 2026 14:25

OCA-git-bot removed the mod:base_external_system Module base_external_system label Apr 24, 2026

	return self.env[self.model_id.model].search(self._eval_domain())
	return self.env[self.sudo().model_id.model].search(self._eval_domain())

		@@ -1,2 +0,0 @@
		* Odoo Community Association: `Icon <https://github.com/OCA/maintainer-tools/blob/master/template/module/static/description/icon.svg>`_
		* All the actual work is done by `Radicale <https://radicale.org>`_


		app = Application(configuration)

		# Let's take WSGI environ from werkzeug/odoo

	environ["wsgi.input"] = io.BytesIO(raw_body)
	environ["wsgi.input"] = request.httprequest._HTTPRequest__wrapped.stream

		_logger = logging.getLogger(__name__)


		def load(configuration):

Uh oh!

Conversation

tendil commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cvinh commented Mar 14, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as resolved.

Uh oh!

cvinh Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Aldeigja Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hbrunn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ikus060 commented Mar 16, 2026

Uh oh!

hbrunn commented Mar 16, 2026

Uh oh!

ikus060 commented Mar 16, 2026

Uh oh!

cvinh commented Mar 16, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tendil commented Mar 17, 2026

Uh oh!

cvinh commented Mar 19, 2026

Uh oh!

tendil commented Mar 20, 2026

Uh oh!

hbrunn left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tendil commented Mar 6, 2026 •

edited

Loading

cvinh Mar 15, 2026 •

edited

Loading

Aldeigja Mar 16, 2026 •

edited

Loading

hbrunn left a comment •

edited

Loading