fix: remove global toFixed calls that interfere with TFAR radios#58
fix: remove global toFixed calls that interfere with TFAR radios#58
Conversation
The standalone `toFixed 2` / `toFixed -1` calls in the capture loop modify engine-wide number formatting state. This corrupts TFAR radio frequency strings (which need 3+ decimal places) during the window between set and reset, making radios unusable.
Summary of ChangesHello @fank, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical compatibility issue where global number formatting changes, inadvertently introduced by OCAP's vehicle capture loop, were interfering with TFAR radio functionality. By removing specific Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses a critical issue by removing global toFixed calls from the per-frame capture loop. These calls were modifying engine-wide number formatting, causing conflicts with other systems like TFAR. The removal of toFixed is the correct approach to prevent such global state corruption. The change will result in vehicle data being sent with full floating-point precision, and the test plan rightly includes verification of the data handling on the receiving end. The fix is clean, targeted, and effectively resolves the reported problem.
Summary
toFixed 2/toFixed -1calls from the vehicle capture loop infnc_captureLoop.sqfTest plan