Open
Conversation
…gacy machines, to have them all in the same directory for server
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4497 +/- ##
==========================================
- Coverage 32.93% 32.57% -0.37%
==========================================
Files 495 495
Lines 58648 58648
==========================================
- Hits 19317 19103 -214
- Misses 35912 36187 +275
+ Partials 3419 3358 -61 |
Contributor
❌ 9 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the Go validation node (
nitro-val) with the Rust validation server (crates/validator) in the nitro-testnode setup. The Rust server is fully compatible with the Go validation client and exposes JIT validation over HTTP JSON-RPC.Changes
Dockerfile
prover-builderstage (alongside jit, prover-lib, prover-bin)nitro-node-devimage at/usr/local/bin//home/user/nitro-legacy/machines/into/home/user/target/machines/so the Rust validator can serve all module roots (latest + legacy) from a single--root-pathstaker/block_validator.gohttp://andhttps://URL schemes for validation server configs (previously onlyws:///wss://were accepted)"result validated"log fromTracetoInfolevel with additional fields (batch,posInBatch) for easier debuggingnitro-testnode (submodule)
docker-compose.yaml: Replacenitro-valwith validator as entrypoint for thevalidation_nodeservice, configure it with CLI args (--address,--root-path), addRUST_LOG=tower_http=debug,infofor HTTP-level request tracing, and add a healthcheck so dependent services wait for the server to be readyscripts/config.ts: Remove jwtsecret from block-validator config (Rust server doesn't use JWT auth)scripts/index.ts: Change default validation node URL fromws://validation_node:8549tohttp://validation_node:4141Reproduction
Expected output
companion PR: OffchainLabs/nitro-testnode#181