Skip to content

Fix codecov comment step failing on workflow_dispatch#4562

Merged
joshuacolvin0 merged 3 commits intomasterfrom
fix/codecov-ci-dispatch-guard
Mar 27, 2026
Merged

Fix codecov comment step failing on workflow_dispatch#4562
joshuacolvin0 merged 3 commits intomasterfrom
fix/codecov-ci-dispatch-guard

Conversation

@joshuacolvin0
Copy link
Copy Markdown
Member

The codecov/basic-test-results action requires a PR context to post
comments. Guard the step so it only runs on pull_request events.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

The codecov/basic-test-results action requires a PR context to post
comments. Guard the step so it only runs on pull_request events.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: looks good

@KolbyML KolbyML assigned eljobe and unassigned KolbyML Mar 25, 2026
@KolbyML KolbyML requested a review from eljobe March 25, 2026 20:43
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.32%. Comparing base (fd2a5b0) to head (4fdddf8).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4562      +/-   ##
==========================================
- Coverage   34.35%   34.32%   -0.03%     
==========================================
  Files         498      498              
  Lines       58977    58977              
==========================================
- Hits        20262    20246      -16     
- Misses      35137    35147      +10     
- Partials     3578     3584       +6     

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 25, 2026

❌ 7 Tests Failed:

Tests completed Failed Passed Skipped
4629 7 4622 0
View the top 3 failed tests by shortest run time
TestAliasingFlaky
Stack Traces | -0.000s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [03-27|19:31:47.311] Imported new potential chain segment     number=47 hash=4f9162..ec49d9 blocks=1  txs=1  mgas=0.021 elapsed="528.977µs" mgasps=39.699   triediffs=224.12KiB triedirty=0.00B
INFO [03-27|19:31:47.311] Chain head was updated                   number=47 hash=4f9162..ec49d9 root=3b2405..b483cf elapsed="41.938µs"
INFO [03-27|19:31:47.312] Ethereum protocol stopped
INFO [03-27|19:31:47.312] Transaction pool stopped
INFO [03-27|19:31:47.312] Starting work on payload                 id=0x03f3c2f3289a03e7
INFO [03-27|19:31:47.312] Updated payload                          id=0x03f3c2f3289a03e7                      number=48 hash=975380..f3bbef txs=0  withdrawals=0 gas=0         fees=0              root=cf215a..1b2aab elapsed="213.268µs"
INFO [03-27|19:31:47.312] Stopping work on payload                 id=0x03f3c2f3289a03e7                      reason=delivery
INFO [03-27|19:31:47.312] Imported new potential chain segment     number=48 hash=975380..f3bbef blocks=1  txs=0  mgas=0.000 elapsed="364.051µs" mgasps=0.000    triediffs=227.24KiB triedirty=0.00B
INFO [03-27|19:31:47.312] Chain head was updated                   number=48 hash=975380..f3bbef root=cf215a..1b2aab elapsed="25.057µs"
INFO [03-27|19:31:47.313] Imported new potential chain segment     number=34 hash=5c8e03..5b5045 blocks=1  txs=1  mgas=2.822 elapsed=1.878ms     mgasps=1501.939 triediffs=181.46KiB triedirty=0.00B
INFO [03-27|19:31:47.313] Persisting dirty state                   head=33 root=22ad1a..98db2c layers=33
WARN [03-27|19:31:47.313] Error performing sealing work            err="blockchain is stopped"
INFO [03-27|19:31:47.313] Submitted transaction                    hash=0x4d6064e44c7537bf33cf00d602fad132637ea9f1a2c03b60004b0ee87265d2db from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=7  recipient=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A value=1,000,000,000,000
INFO [03-27|19:31:47.313] Starting work on payload                 id=0x0334ccc0091c60f9
INFO [03-27|19:31:47.313] Updated payload                          id=0x0334ccc0091c60f9                      number=49 hash=934716..644f81 txs=1  withdrawals=0 gas=21000     fees=0.002094555426 root=8fc044..c9624d elapsed="323.584µs"
INFO [03-27|19:31:47.314] Persisted dirty state to disk            size=162.75KiB elapsed=1.082ms
INFO [03-27|19:31:47.314] Stopping work on payload                 id=0x0334ccc0091c60f9                      reason=delivery
INFO [03-27|19:31:47.314] Blockchain stopped
INFO [03-27|19:31:47.314] Imported new potential chain segment     number=49 hash=934716..644f81 blocks=1  txs=1  mgas=0.021 elapsed="540.248µs" mgasps=38.871   triediffs=231.23KiB triedirty=0.00B
INFO [03-27|19:31:47.314] Chain head was updated                   number=49 hash=934716..644f81 root=8fc044..c9624d elapsed="22.171µs"
TestBatchPosterL1SurplusMatchesBatchGasFlaky
Stack Traces | 0.550s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
panic: runtime error: invalid memory address or nil pointer dereference [recovered, repanicked]
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x2079f52]

goroutine 16 [running]:
testing.tRunner.func1.2({0x37dd320, 0x61ec9b0})
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1872 +0x237
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1875 +0x35b
panic({0x37dd320?, 0x61ec9b0?})
	/opt/hostedtoolcache/go/1.25.8/x64/src/runtime/panic.go:783 +0x132
github.com/offchainlabs/nitro/arbnode.(*InboxTracker).GetBatchCount(0x14f85900?)
	/home/runner/work/nitro/nitro/arbnode/inbox_tracker.go:210 +0x12
github.com/offchainlabs/nitro/arbnode.(*InboxTracker).FindInboxBatchContainingMessage(0x0, 0x8)
	/home/runner/work/nitro/nitro/arbnode/inbox_tracker.go:225 +0x2f
github.com/offchainlabs/nitro/system_tests.TestBatchPosterL1SurplusMatchesBatchGasFlaky(0xc000503180)
	/home/runner/work/nitro/nitro/system_tests/batch_poster_test.go:838 +0x725
testing.tRunner(0xc000503180, 0x41ae150)
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1934 +0xea
created by testing.(*T).Run in goroutine 1
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1997 +0x465
TestAnyTrustRekey
Stack Traces | 23.070s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
        testing.tRunner(0xc0004008c0, 0x44c0740)
        	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1997 +0x465
        
INFO [03-27|19:37:09.635] Starting work on payload                 id=0x0326b41a1b6b7f61
INFO [03-27|19:37:09.636] Imported new potential chain segment     number=176 hash=c0b63d..1ebd64 blocks=1  txs=1   mgas=0.021  elapsed=1.646ms      mgasps=12.751   triediffs=680.86KiB triedirty=62.33KiB
INFO [03-27|19:37:09.636] Chain head was updated                   number=176 hash=c0b63d..1ebd64 root=0261e4..806c6b elapsed="107.27µs"
    common_test.go:983: �[31;1m [failed to deploy ArbDebug] nonce too low: address 0x26E554a8acF9003b83495c7f45F06edCB803d4e3, tx: 1 state: 3 �[0;0m
WARN [03-27|19:37:09.637] error getting max time variation on L1 bound block; falling back on latest block err="context canceled"
--- FAIL: TestAnyTrustRekey (23.07s)
INFO [03-27|19:37:09.639] Updated payload                          id=0x0326b41a1b6b7f61 number=114 hash=dcf285..3baa8f txs=1   withdrawals=0 gas=21000      fees=0.002099999042 root=60ec39..648c45 elapsed=2.919ms
WARN [03-27|19:37:09.640] Sequencer ReadFromTxQueueTimeout is higher than MaxBlockSpeed ReadFromTxQueueTimeout=1s MaxBlockSpeed=10ms
WARN [03-27|19:37:09.640] Sanitizing invalid node buffer size      provided=1024.00MiB updated=256.00MiB
INFO [03-27|19:37:09.640] Load database journal from disk
INFO [03-27|19:37:09.641] State snapshot generator is not found
INFO [03-27|19:37:09.641] Starting snapshot generation             root=56e81f..63b421 accounts=0 slots=0 storage=0.00B dangling=0 elapsed="3.827µs"
INFO [03-27|19:37:09.641] Initialized path database                triecache=600.00MiB statecache=400.00MiB buffer=256.00MiB state-history="last 345600 blocks"
INFO [03-27|19:37:09.642] addresss table import complete
INFO [03-27|19:37:09.642] retryables import complete

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@eljobe eljobe enabled auto-merge March 27, 2026 11:05
@eljobe eljobe added this pull request to the merge queue Mar 27, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 27, 2026
@joshuacolvin0 joshuacolvin0 enabled auto-merge March 27, 2026 19:15
@joshuacolvin0 joshuacolvin0 added this pull request to the merge queue Mar 27, 2026
Merged via the queue into master with commit 0973192 Mar 27, 2026
25 checks passed
@joshuacolvin0 joshuacolvin0 deleted the fix/codecov-ci-dispatch-guard branch March 27, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants