[Snyk] Security upgrade @expo/plist from 0.0.17 to 0.3.0#90
[Snyk] Security upgrade @expo/plist from 0.0.17 to 0.3.0#90revan-zhang wants to merge 2 commits intomainfrom
Conversation
…ck to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-XMLDOMXMLDOM-15869636
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
| "@actions/core": "^1.9.1", | ||
| "@expo/json-file": "^8.2.34", | ||
| "@expo/plist": "^0.0.17", | ||
| "@expo/plist": "^0.3.0", |
There was a problem hiding this comment.
🔴 Bundled index.js not rebuilt after dependency upgrade, so the vulnerability fix has no runtime effect
The PR updates @expo/plist from ^0.0.17 to ^0.3.0 in package.json and yarn.lock to reduce vulnerabilities, but the pre-compiled build-plist-edit/index.js bundle (which is what action.yml:19 actually executes via runs.main: 'index.js') was not rebuilt. The build step is ncc build index.ts -m -o ../ (build-plist-edit/src/package.json:7), which bundles all dependencies into a single index.js. Since index.js still contains the old @expo/plist@0.0.17 code (with vulnerable @xmldom/xmldom@~0.7.0 and xmlbuilder@^14.0.0), the upgrade has zero runtime effect — the action will continue running the old vulnerable code.
Prompt for agents
The build-plist-edit action uses @vercel/ncc to bundle all source code and dependencies into a single build-plist-edit/index.js file, which is the actual entry point referenced in action.yml. The PR updated package.json and yarn.lock but did not re-run the build step (cd build-plist-edit/src && yarn build, which runs ncc build index.ts -m -o ../). As a result, the bundled index.js still contains the old @expo/plist@0.0.17 code with its vulnerable transitive dependencies. To fix: run 'yarn build' from the build-plist-edit/src directory and commit the regenerated index.js.
Was this helpful? React with 👍 or 👎 to provide feedback.
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
build-plist-edit/src/package.jsonbuild-plist-edit/src/yarn.lockNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-XMLDOMXMLDOM-15869636
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 XML Injection
Note
Medium Risk
Dependency-only change, but it upgrades the plist parser/builder stack (including
@xmldom/xmldomandxmlbuilder), which could subtly changeplist.parse/plist.buildbehavior for generatedInfo.plistfiles.Overview
Updates
@expo/plistfrom0.0.17to0.3.xinbuild-plist-edit, along with lockfile updates pulling newer@xmldom/xmldomandxmlbuilderversions to remediate an XML injection vulnerability.No application code changes; runtime impact is limited to how plist files are parsed/built by the
build-plist-editscript.Written by Cursor Bugbot for commit 533c409. This will update automatically on new commits. Configure here.