Skip to content

[Snyk] Security upgrade @actions/cache from 1.0.8 to 4.0.0#91

Open
revan-zhang wants to merge 2 commits intomainfrom
snyk-fix-f316472c3cf57a831ce04283d498bb16
Open

[Snyk] Security upgrade @actions/cache from 1.0.8 to 4.0.0#91
revan-zhang wants to merge 2 commits intomainfrom
snyk-fix-f316472c3cf57a831ce04283d498bb16

Conversation

@revan-zhang
Copy link
Copy Markdown
Collaborator

@revan-zhang revan-zhang commented Apr 3, 2026

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • expo-server/package.json
  • expo-server/yarn.lock

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Infinite loop
SNYK-JS-BRACEEXPANSION-15789759
  555  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.


Open with Devin

Note

Medium Risk
Upgrades a core GitHub Actions dependency (@actions/cache) across major versions, which could introduce behavior/API differences in caching and its transitive Azure/HTTP stack.

Overview
Updates expo-server to use @actions/cache ^4.0.0 (from ^1.0.8) to address a reported vulnerability.

Regenerates yarn.lock accordingly, pulling in newer transitive dependencies (notably updated @actions/* HTTP/core packages and newer Azure storage/cache-related libraries).

Written by Cursor Bugbot for commit d963624. This will update automatically on new commits. Configure here.

@revan-zhang
Copy link
Copy Markdown
Collaborator Author

revan-zhang commented Apr 3, 2026

Snyk checks have failed. 5 issues have been found so far.

Status Scan Engine Critical High Medium Low Total (5)
Open Source Security 0 2 3 0 5 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 2 additional findings in Devin Review.

Open in Devin Review

},
"dependencies": {
"@actions/cache": "^1.0.8",
"@actions/cache": "^4.0.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Build output not regenerated after @actions/cache v1→v4 upgrade, making the change a no-op at runtime

The build/ directory contains ncc-bundled code that GitHub Actions actually executes (per action.yml:19main: build/setup/index.js). The PR updates @actions/cache from ^1.0.8 to ^4.0.0 in package.json and yarn.lock, but does not regenerate the build output. The bundled build/setup/index.js still contains the old v1 cache library code — confirmed by the absence of any v4-specific symbols (getCacheServiceVersion, cacheTwirpClient, ACTIONS_RESULTS_URL) in the build output, while v1-only patterns remain. This means the dependency upgrade has zero effect at runtime and the commit message's stated goal ("reduce vulnerabilities") is not achieved. The CONTRIBUTING.md explicitly requires: "Run yarn build to ensure the build is up-to-date and runs correctly and without errors or warnings."

Prompt for agents
The build/ directory is bundled via ncc (see expo-server/ncc.js) and is what GitHub Actions actually runs at runtime (action.yml main: build/setup/index.js). After changing the @actions/cache dependency version in package.json, you must regenerate the build output by running `yarn build` (or `node ncc.js`) from the expo-server directory. Without this step, the bundled code in build/setup/index.js, build/command/index.js, and build/preview-comment/index.js still contains the old @actions/cache v1 code, making the entire dependency upgrade ineffective at runtime. Run the build and commit the updated build/ output.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants