Disable concurrency for sync mode webhook triggers#4570
Draft
taylordowns2000 wants to merge 2 commits intomainfrom
Draft
Disable concurrency for sync mode webhook triggers#4570taylordowns2000 wants to merge 2 commits intomainfrom
taylordowns2000 wants to merge 2 commits intomainfrom
Conversation
When a workflow's trigger uses sync/response mode (webhook_reply: after_completion), the concurrency setting is not respected, so we disable the input and show an info icon tooltip plus explanatory text. https://claude.ai/code/session_01A2Cryi5yc1wWpYiS1tT5E8
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4570 +/- ##
==========================================
+ Coverage 89.49% 89.51% +0.01%
==========================================
Files 441 441
Lines 21111 21111
==========================================
+ Hits 18894 18897 +3
+ Misses 2217 2214 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #4569
This PR adds a label to warn about the strange behaviour of sync-mode triggers, with respect to concurrency. When a webhook trigger is configured with sync mode, most OpenFn instances ignore the limit.
Validation steps
Additional notes for the reviewer
WorkerPresencesolution that check to see if any workers are subscribed tofast_lanesor*, but even this isn't rock solid, as you might set the setting today and have your superuser change the queues tomorrow.AI Usage
Pre-submission checklist
/reviewwith Claude Code):owner,:admin,:editor,:viewer)