Skip to content

Minor cleanup on filter/search#4580

Merged
taylordowns2000 merged 9 commits intomainfrom
cleanup
Mar 30, 2026
Merged

Minor cleanup on filter/search#4580
taylordowns2000 merged 9 commits intomainfrom
cleanup

Conversation

@taylordowns2000
Copy link
Copy Markdown
Member

@taylordowns2000 taylordowns2000 commented Mar 28, 2026

This PR closes #4579 with style-only changes to the filters/search bar on history, saving a bit of real-estate and making the page better handle small screens.

https://www.loom.com/share/a0cdd98aa6ae457aba03b111813e899a

It takes us from this:

image

To this:

image

Validation steps

  1. Navigate around filters/search on history (channel and work orders)

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

Pre-submission checklist

  • I have performed an AI review of my code (we recommend using /review
    with Claude Code)
  • I have implemented and tested all related authorization policies.
    (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

@github-project-automation github-project-automation bot moved this to New Issues in Core Mar 28, 2026
@taylordowns2000 taylordowns2000 changed the title close #4579 Minor cleanup on filter/search Mar 28, 2026
@taylordowns2000 taylordowns2000 marked this pull request as ready for review March 28, 2026 07:53
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

❌ Patch coverage is 93.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.51%. Comparing base (b4f8dce) to head (b1d810b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/lightning_web/live/run_live/index.ex 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4580      +/-   ##
==========================================
- Coverage   89.54%   89.51%   -0.04%     
==========================================
  Files         441      441              
  Lines       21214    21249      +35     
==========================================
+ Hits        18997    19020      +23     
- Misses       2217     2229      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@brandonjackson brandonjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@taylordowns2000 taylordowns2000 merged commit 2a78d3e into main Mar 30, 2026
7 of 8 checks passed
@github-project-automation github-project-automation bot moved this from New Issues to Done in Core Mar 30, 2026
@taylordowns2000 taylordowns2000 deleted the cleanup branch March 30, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Minimal redesign for filter/search on history

2 participants