Allow special characters and non-Latin scripts in job names#4594
Open
m4cd4r4 wants to merge 1 commit intoOpenFn:mainfrom
Open
Allow special characters and non-Latin scripts in job names#4594m4cd4r4 wants to merge 1 commit intoOpenFn:mainfrom
m4cd4r4 wants to merge 1 commit intoOpenFn:mainfrom
Conversation
The name validation regex blocked non-ASCII characters, preventing users who speak non-English languages from using native scripts (Arabic, French accents, etc.) in their workflow step names. Step names are treated as labels in the YAML export, not as identifiers, so the restriction was unnecessary. Removes the character-set validation from the Elixir changeset, the PlaceholderJob React component, and the collaborative editor Zod schema. The 100-character length limit is kept. Fixes OpenFn#4577
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4577
Workflow step names are stored as labels in YAML exports, not as
identifiers. The existing regex (
/^[a-zA-Z0-9_\- ]*$/) was unnecessarilyblocking non-English users from entering names in their native scripts
(Arabic, French, Chinese, etc.) or using characters like
@or'.Removes the character-set restriction from three locations:
lib/lightning/workflows/job.ex- Elixir changeset validationassets/js/workflow-diagram/nodes/PlaceholderJob.tsx- PlaceholderJob inline validationassets/js/collaborative-editor/types/job.ts- Zod schema for collaborative editorThe 100-character length limit and blank-name check are preserved.
Validation steps
mix formatmix test test/lightning/workflows/job_test.exs --seed 0Checklist