D006 ModelicaSystem - small fixes#436
Open
syntron wants to merge 17 commits intoOpenModelica:masterfrom
Open
Conversation
[ModelicaSystemDoE] simplify definition; use a Modelicasystem instance as argument [ModelicaSystemDoE] update docstring [ModelicaSystemDoE] fix for relative paths [ModelicaSystemDoE] fix unittest * test_ModelicaSystemDoE_local is tested * test_ModelicaSystemDoE_docker should work * test_ModelicaSystemDoE_WSL is untested
[ModelExecution*] create classes to handle model execution * rename ModelicaSystemCmd => ModelExecutionCmd * rename OMCSessionRunData => ModelExecutionData * create class ModelExecutionException * move some code: * OMCSession.omc_run_data_update() => merge into ModelExecutionCmd.define() * OMCSession.run_model_executable() => ModelExecutionData.run() [test_ModelicaSystemCmd] update unittest [ModelExecutionData] include the original exception if reraised as ModelExecutionException [ModelicaSystem] fix usage of ModelicaSystemCmd
…existable exists and can be executed
[ModelicaSystem] split ModelicaSystem into ModelicaSystemABC and ModelicaSystem [ModelicaSystem] rename ModelicaSystem => ModelicaSystemOMC * add compatibility variable for ModelicaSystem [test_ModelicaSystemOMC] rename from ModelicaSystem and update [test_*] use ModelicaSystemOMC [ModelicaSystem*] fix last usages of ModelicaSystem() in comments & docstrings
[ModelicaSystem] split ModelicaSystemDoE into ModelicaDoEABC and ModelicaDoE [ModelicaSystem] rename ModelicaSystemDoE => ModelicaDoEOMC * add compatibility variable for ModelicaSystemDoE [test_ModelicaDoEOMC] rename from ModelicaSystemDoE and update [ModelicaSystem] update ModelicaDoEABC to use ModelicaSystemABC [ModelicaSystem] define doe_get_solutions() as separate method
[OMCSession] update OMCPath to use OMPathABC as baseline and further cleanup [ModelicaSystem] shortcut to use OMCPath = OMPathABC for now [ModelicaSystem] fix usage of OMCPath; replace by OMPathABC [OMCSession] move OM(C)Path classes into the if cause [OMCSession] define and use OMPathBase [OMCSession] align on OMPathABC; replace usage of OMPathBase
[OMCSession] update OMCSession* to use OMSessionABC as baseline and further cleanup [ModelicaSystem] shortcut to use OMCSession = OMSessionABC for now [ModelicaSystem] fix usage of OMCSession; replace by OMSessionABC fix usage of OMCSession [OMSessionABC] fix OMCPath; rename to OMPathABC
[OMCSession] add *Runner related classes for OMPath and OMSession [ModelicaSystem] add ModelicaSystemRunner [test_ModelicaSystemRunner] add test case for ModelicaSystemRunner [ModelicaSystem] add ModelicaDoERunner [test_ModelicaDoERunner] add test case for ModelicaDoERunner [OMCSession] move OMCPathRunner* into the if clause [OMSessionRunner] fix usage of sendExpression() [__init__] add missing definitions for *Runner classes [ModelicaDoERunner] fix definition; allow all variations of ModelicaSystem* [test_ModelicaDoERunner] fix definition; test ModelicaSystem(OCM|Runner) [ModelicaDoEABC] add get_resultpath()
* comments * prepare cmd_prefix handling within OMSession * fix timeout handling
[__init__] define OMSessionABC in the public interface [OMCSessionZMQ] move class definition such that it can be derived from OMSessionABC * needed for the compatibility layer
[OMPathABC] improve definition * add get_session() * fix return values [(_)OMCPath] improve definition * check return value from OMC * define return value for methods
[(_)OMPathRunnerLocal] improve definition * fix return values * additional cleanups [__init__] define OMPathRunnerLocal for public interface [_OMPathRunnerBash] define class [__init__] define OMPathRunnerBash for public interface [OMSessionRunner] update code such that it can be used by OMPathRunnerLocal and OMPathRunner Bash
[OMCSessionPort] fix timeout handling [OMCSessionDocker*] improve data handling * move more code to OMCSessionDockerHelper * use _docker_omc_start() to differentiate classes * define cmd_prefix [OMCSessionWSL] define cmd_prefix [OMCSessionWSL] layout fix
[ModelicaSystemABC] reorder code in __init__() [ModelicaSystem*] linter fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(D006) small fixes in ModelicaSystem