Feature/two finger rotation and gesture settings#2491
Open
iwahage wants to merge 10 commits intoOpenOrienteering:masterfrom
Open
Feature/two finger rotation and gesture settings#2491iwahage wants to merge 10 commits intoOpenOrienteering:masterfrom
iwahage wants to merge 10 commits intoOpenOrienteering:masterfrom
Conversation
[codex] Improve Android mobile toolbar customization and edge-to-edge UI
In mobile mode, map_widget lives inside a container_widget (QVBoxLayout with bottom_action_bar). MapEditorController::detach() was calling setCentralWidget(nullptr), which does nothing because QStackedWidget ignores null, and then deleting map_widget individually, leaving a dangling pointer in the container's layout. When the app later left fullscreen mode, resize events reached the stale container and accessed freed memory, causing a freeze. Fix: pass a new empty QWidget to setCentralWidget() so the old container is properly removed from the QStackedWidget and scheduled for deletion. Also change the cleanup loop in MainWindow::setCentralWidget() from `if` to `while` to handle edge cases with multiple stacked widgets. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix Android freeze when discarding changes on close
Fix multiple template rendering issues on Android: - Fix template flicker/offset during auto-rotation by excluding pan_offset from cache state recording and comparing transforms without pan_offset in drawTemplateCache - Fix persistent flickering by disabling deferred template cache updates that caused 2-frame visual glitches - Render map and templates in uncovered regions during pinch zoom-out instead of showing gray, using the same composite transform as the scaled cache for perfect alignment - Render map and templates in uncovered regions during pan drag instead of showing gray - Add tiled drawing for template images with source_rect clipping Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…dering Fix template cache rendering during auto-rotation, pan, and pinch zoom
…ring - Add two-finger rotation support during pinch gestures when auto-rotation (compass) is OFF. Rotation is applied around the pinch center with correct view center compensation on release. - Render map/templates in uncovered regions during pinch rotation (not just zoom-out), using the same composite transform for perfect alignment with the scaled/rotated cache. - Add "Gesture uncovered area" setting with 3 levels: Off (gray), Templates only (default), Full (templates + map). This allows lower-end devices to trade visual quality for smoother gesture performance. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
iwahage
force-pushed
the
feature/two-finger-rotation-and-gesture-settings
branch
from
83e2f5b to
6b5fa3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.