chore: promote four modules to Production/Stable#115
Conversation
Set spp_hazard, spp_cel_registry_search, spp_hazard_programs, and spp_import_match to Stable release status.
…dules Set development_status to Production/Stable, remove reichie020212, and ensure emjay0921 is listed as maintainer on spp_hazard, spp_cel_registry_search, spp_hazard_programs, and spp_import_match.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request promotes four OpenSPP modules to Production/Stable status, reflecting their increased maturity and reliability. It also updates the maintainer list and regenerates documentation files to reflect these changes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request promotes four modules (spp_hazard, spp_cel_registry_search, spp_hazard_programs, and spp_import_match) to "Production/Stable" status and updates their maintainer lists. The changes are consistent across the __manifest__.py files and the auto-generated README.rst and index.html files. The changes align with the summary provided. I have one minor suggestion regarding file formatting consistency.
|
|
||
| This module is part of the `OpenSPP/OpenSPP2 <https://github.com/OpenSPP/OpenSPP2/tree/19.0/spp_cel_registry_search>`_ project on GitHub. | ||
|
|
||
| You are welcome to contribute. No newline at end of file |
There was a problem hiding this comment.
This file is missing a final newline, which is a standard convention for text files to ensure proper handling by various tools. The other README.rst files updated in this pull request include a final newline. This inconsistency might stem from the oca-gen-addon-readme tool, potentially when the maintainers list is added to a manifest for the first time. To ensure consistency across all generated files, it would be beneficial to investigate and adjust the generation template or tool.
There was a problem hiding this comment.
Valid observation, but not actionable in this PR. The file is auto-generated by the oca-gen-addon-readme pre-commit hook, which produces output without a trailing newline. Any manual fix gets overwritten on the next hook run. This would need to be addressed upstream in the OCA maintainer-tools.
…test Replace unsupported startsWith() with equality match in test_compile_expression_with_offset to fix pre-existing test failure.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 19.0 #115 +/- ##
========================================
Coverage 70.14% 70.15%
========================================
Files 739 741 +2
Lines 43997 44316 +319
========================================
+ Hits 30863 31090 +227
- Misses 13134 13226 +92
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
2 participants
Summary
development_statusfromBetatoProduction/Stableforspp_hazard,spp_cel_registry_search,spp_hazard_programs, andspp_import_matchChanges per module
spp_hazardspp_cel_registry_searchspp_hazard_programsspp_import_matchTest plan
spp_hazard— all tests passspp_hazard_programs— all tests passspp_import_match— all tests passspp_cel_registry_search— 1 pre-existing failure (unrelatedstartsWithCEL function)