Skip to content

Add support for Wellturn T330 shocker#285

Open
hhvrc wants to merge 2 commits intodevelopfrom
feat/add-support-for-wellturn-t330
Open

Add support for Wellturn T330 shocker#285
hhvrc wants to merge 2 commits intodevelopfrom
feat/add-support-for-wellturn-t330

Conversation

@hhvrc
Copy link
Contributor

@hhvrc hhvrc commented Mar 16, 2026

No description provided.

@hhvrc hhvrc requested review from LucHeart and Copilot March 16, 2026 12:59
@hhvrc hhvrc self-assigned this Mar 16, 2026
@hhvrc hhvrc added the enhancement New feature or request label Mar 16, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for a new shocker model type, "Wellturn T330", by introducing a new enum value, updating the FlatBuffers serialization mapper, registering the new value in the database context, and bumping the OpenShock.Serialization.Flatbuffers package from 2.0.0-preview.5 to 2.1.0. A new EF Core migration is included to apply the database enum change.

Changes:

  • Added WellturnT330 = 3 to the ShockerModelType enum and its FlatBuffers mapper
  • Updated the OpenShock.Serialization.Flatbuffers package to 2.1.0
  • Added EF Core migration 20260316125819_AddWellturnT330 for the new enum value

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Common/Models/ShockerModelType.cs Added WellturnT330 = 3 enum value with [PgName("wellturnT330")]
LiveControlGateway/Mappers/FbsMapper.cs Added mapping for WellturnT330 to FlatBuffers serialization type
Common/OpenShockDb/OpenShockContext.cs Added "wellturnT330" to the shocker_model_type Postgres enum definition
Directory.Packages.props Bumped OpenShock.Serialization.Flatbuffers from 2.0.0-preview.5 to 2.1.0
Common/Migrations/20260316125819_AddWellturnT330.cs New migration — incorrectly generated as full initial migration
Common/Migrations/20260316125819_AddWellturnT330.Designer.cs Migration designer file — uses wrong DbContext type
Common/Migrations/OpenShockContextModelSnapshot.cs Updated model snapshot — uses wrong DbContext type
Files not reviewed (1)
  • Common/Migrations/20260316125819_AddWellturnT330.Designer.cs: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the Wellturn T330 shocker model by introducing a new enum value across the model, database, serialization, and mapping layers. It also bumps the OpenShock.Serialization.Flatbuffers package from 2.0.0-preview.5 to 2.1.0.

Changes:

  • Added WellturnT330 = 3 to the ShockerModelType enum and registered it in the Postgres enum and FlatBuffers mapper.
  • Created a new EF Core migration to add the wellturnT330 value to the shocker_model_type Postgres enum.
  • Bumped OpenShock.Serialization.Flatbuffers to 2.1.0 (which includes the new WellturnT330 serialization type).

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Common/Models/ShockerModelType.cs Added WellturnT330 = 3 enum member with [PgName("wellturnT330")]
LiveControlGateway/Mappers/FbsMapper.cs Added mapping from WellturnT330 to FlatBuffers WellturnT330
Common/OpenShockDb/OpenShockContext.cs Added "wellturnT330" to the Postgres enum definition
Directory.Packages.props Bumped OpenShock.Serialization.Flatbuffers from 2.0.0-preview.5 to 2.1.0
Common/Migrations/20260316125819_AddWellturnT330.cs New migration to alter the shocker_model_type Postgres enum
Common/Migrations/20260316125819_AddWellturnT330.Designer.cs Auto-generated migration designer file
Common/Migrations/OpenShockContextModelSnapshot.cs Updated model snapshot with new enum value and EF Core 10 metadata
Files not reviewed (1)
  • Common/Migrations/20260316125819_AddWellturnT330.Designer.cs: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants