Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for a new shocker model type, "Wellturn T330", by introducing a new enum value, updating the FlatBuffers serialization mapper, registering the new value in the database context, and bumping the OpenShock.Serialization.Flatbuffers package from 2.0.0-preview.5 to 2.1.0. A new EF Core migration is included to apply the database enum change.
Changes:
- Added
WellturnT330 = 3to theShockerModelTypeenum and its FlatBuffers mapper - Updated the
OpenShock.Serialization.Flatbufferspackage to2.1.0 - Added EF Core migration
20260316125819_AddWellturnT330for the new enum value
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Common/Models/ShockerModelType.cs | Added WellturnT330 = 3 enum value with [PgName("wellturnT330")] |
| LiveControlGateway/Mappers/FbsMapper.cs | Added mapping for WellturnT330 to FlatBuffers serialization type |
| Common/OpenShockDb/OpenShockContext.cs | Added "wellturnT330" to the shocker_model_type Postgres enum definition |
| Directory.Packages.props | Bumped OpenShock.Serialization.Flatbuffers from 2.0.0-preview.5 to 2.1.0 |
| Common/Migrations/20260316125819_AddWellturnT330.cs | New migration — incorrectly generated as full initial migration |
| Common/Migrations/20260316125819_AddWellturnT330.Designer.cs | Migration designer file — uses wrong DbContext type |
| Common/Migrations/OpenShockContextModelSnapshot.cs | Updated model snapshot — uses wrong DbContext type |
Files not reviewed (1)
- Common/Migrations/20260316125819_AddWellturnT330.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
This PR adds support for the Wellturn T330 shocker model by introducing a new enum value across the model, database, serialization, and mapping layers. It also bumps the OpenShock.Serialization.Flatbuffers package from 2.0.0-preview.5 to 2.1.0.
Changes:
- Added
WellturnT330 = 3to theShockerModelTypeenum and registered it in the Postgres enum and FlatBuffers mapper. - Created a new EF Core migration to add the
wellturnT330value to theshocker_model_typePostgres enum. - Bumped
OpenShock.Serialization.Flatbuffersto2.1.0(which includes the newWellturnT330serialization type).
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Common/Models/ShockerModelType.cs | Added WellturnT330 = 3 enum member with [PgName("wellturnT330")] |
| LiveControlGateway/Mappers/FbsMapper.cs | Added mapping from WellturnT330 to FlatBuffers WellturnT330 |
| Common/OpenShockDb/OpenShockContext.cs | Added "wellturnT330" to the Postgres enum definition |
| Directory.Packages.props | Bumped OpenShock.Serialization.Flatbuffers from 2.0.0-preview.5 to 2.1.0 |
| Common/Migrations/20260316125819_AddWellturnT330.cs | New migration to alter the shocker_model_type Postgres enum |
| Common/Migrations/20260316125819_AddWellturnT330.Designer.cs | Auto-generated migration designer file |
| Common/Migrations/OpenShockContextModelSnapshot.cs | Updated model snapshot with new enum value and EF Core 10 metadata |
Files not reviewed (1)
- Common/Migrations/20260316125819_AddWellturnT330.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.