Skip to content

Feature/shocker menu#170

Open
LucHeart wants to merge 9 commits intodevelopfrom
feature/shocker-menu
Open

Feature/shocker menu#170
LucHeart wants to merge 9 commits intodevelopfrom
feature/shocker-menu

Conversation

@LucHeart
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2026

⚠️ No Changeset found

Latest commit: 83ec1ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 17, 2026

Deploying openshockapp with  Cloudflare Pages  Cloudflare Pages

Latest commit: 83ec1ac
Status: ✅  Deploy successful!
Preview URL: https://1983dcd9.openshockapp.pages.dev
Branch Preview URL: https://feature-shocker-menu.openshockapp.pages.dev

View logs

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8038f7c967

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

}

let { open = $bindable(), userInput = $bindable() }: Props = $props();
let redeemPromise = $state<Promise<V2UserSharesListItem> | null>(null);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Reintroduce the removed redeemed state variable

Removing the redeemed declaration leaves onOpenChange and onFormSubmit still assigning to redeemed, which will throw ReferenceError: redeemed is not defined when the dialog closes or after a successful redeem. That breaks the redeem flow at runtime in this component even though only the declaration was deleted in this patch.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant