Skip to content

Fix filtering Support gems in SkillsTab #9669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Peechey wants to merge 4 commits into
base: dev
Choose a base branch
from
+4 −3
Open

Fix filtering Support gems in SkillsTab #9669

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41ff01a
fix exceptional support gem filtering
Peechey Mar 18, 2026
01e0720
update the gemList populate
Peechey Mar 18, 2026
bbaa1ee
only show plusVersionOf for legacy gems like Awakened... otherwise on…
Peechey Mar 21, 2026
291b7c2
update other conditional as well
Peechey Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Classes/GemSelectControl.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ function GemSelectClass:PopulateGemList()
if (self.sortGemsBy and gemData.tags[self.sortGemsBy] == true or not self.sortGemsBy) then
local levelRequirement = gemData.grantedEffect.levels[1].levelRequirement or 1
if characterLevel >= levelRequirement or not matchLevel then
if (showExceptional or showAll) and gemData.grantedEffect.plusVersionOf then
if (showExceptional or showAll) and ((gemData.grantedEffect.legacy and gemData.grantedEffect.plusVersionOf) or gemData.tagString:match("Exceptional")) then
if self.skillsTab.showLegacyGems or not gemData.grantedEffect.legacy then
self.gems["Default:" .. gemId] = gemData
end
Expand All @@ -139,13 +139,14 @@ end

function GemSelectClass:FilterSupport(gemId, gemData)
local showSupportTypes = self.skillsTab.showSupportGemTypes
local isLegacyAwakened = (gemData.grantedEffect.legacy and gemData.grantedEffect.plusVersionOf)
if gemData.grantedEffect.legacy and not self.skillsTab.showLegacyGems then
return false
end
return (not gemData.grantedEffect.support
or showSupportTypes == "ALL"
or (showSupportTypes == "NORMAL" and not gemData.grantedEffect.plusVersionOf)
or (showSupportTypes == "EXCEPTIONAL" and gemData.grantedEffect.plusVersionOf))
or (showSupportTypes == "NORMAL" and not (isLegacyAwakened or gemData.tagString:match("Exceptional")))
or (showSupportTypes == "EXCEPTIONAL" and (isLegacyAwakened or gemData.tagString:match("Exceptional"))))
and (self.skillsTab.showAltQualityGems or (not self.skillsTab.showAltQualityGems and self:GetQualityType(gemId) == "Default"))
end

Expand Down
Loading