Skip to content

Add support for Imbued Supports#9670

Open
Peechey wants to merge 12 commits intoPathOfBuildingCommunity:devfrom
Peechey:feature/imbued-support-implementation
Open

Add support for Imbued Supports#9670
Peechey wants to merge 12 commits intoPathOfBuildingCommunity:devfrom
Peechey:feature/imbued-support-implementation

Conversation

@Peechey
Copy link
Contributor

@Peechey Peechey commented Mar 19, 2026

Description of the problem being solved:

Full implementation of Imbued Supports, including Importing from Character, Saving and Loading to the XML, and fixing "too many gems in slot" warning. The selection automatically filters for Level 1 Non-Exceptional Support gems. The colour of "Imbued Support:" will follow the application options Positive Values Hex colour.

You are only allowed one imbued support per Slot.

  • If a socketGroup is socketed in and has an imbued and you remove the socketed in, the imbued will be removed.
  • If there is an imbued support socketed in Helmet in group 1, and group 2 is also socketed in Helmet, you will not be allowed to select an imbued for group 2. If group 2 is socketed in e.g. Boots with an imbued and then changed to Helmet, the imbued on group 2 is removed.

PS: This PR also removes the Variant column in the skillsTab. It happened long enough ago I forgot it was in this branch. If you don't want it in this change, let me know.

After screenshot:

image ` image ` image ` image
<Skill label="" enabled="true" slot="Helmet" mainActiveSkill="1" mainActiveSkillCalcs="1" imbuedSupport="Spell Echo" includeInFullDPS="false">
		<Gem enabled="true" quality="0" variantId="FlameSurge" skillId="FlameSurge" level="20" enableGlobal1="true" count="1" enableGlobal2="true" nameSpec="Flame Surge" gemId="Metadata/Items/Gems/SkillGemFlameWhip"/>
		<Gem enabled="true" quality="0" variantId="SupportInvertTheRules" skillId="SupportInvertTheRules" level="3" enableGlobal1="true" count="1" enableGlobal2="true" nameSpec="Invert the Rules" gemId="Metadata/Items/Gems/SupportGemInvertTheRules"/>
		<Gem enabled="true" quality="0" variantId="SupportArcaneSurge" skillId="SupportArcaneSurge" level="20" enableGlobal1="true" count="1" enableGlobal2="true" nameSpec="Arcane Surge" gemId="Metadata/Items/Gems/SupportGemArcaneSurge"/>
		<Gem enabled="true" quality="0" variantId="SupportCullingStrike" skillId="SupportCullingStrike" level="20" enableGlobal1="true" count="1" enableGlobal2="true" nameSpec="Culling Strike" gemId="Metadata/Items/Gems/SupportGemCullingStrike"/>
</Skill>

@Peechey Peechey added the enhancement New feature, calculation, or mod label Mar 19, 2026
@Blitz54
Copy link
Contributor

Blitz54 commented Mar 22, 2026

I found a few issues. (sorry)

The hover tooltip on the imbued shows the tooltip for the second gem in the socket group. Whether it be a support or an active gem. If there is no second gem, no tooltip pops up.

Opening the Imbued selection then clicking away to close it, will cause the imbued select to change to the top most support, instead of reverting to the current selected gem.

Related to the first two, the tooltip does not show on Import until a change is made (quality, count, new gem, etc). Then it will follow the logic above.

Typing to search for the gems is different than the normal dropdowns. I can't type "spell" to have spell echo show up. With Fireball as the skill. I type s, it auto fills with Sacrifice. Then, any further letters are added onto that gem name, so "Sacrificepell".

If you backspace to remove the text, once it's fully erased, backspacing again will show the hex color code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants