Add support for Imbued Supports#9670
Add support for Imbued Supports#9670Peechey wants to merge 12 commits intoPathOfBuildingCommunity:devfrom
Conversation
…e else because it's an infestation
…s an imbued don't show imbued label/dropdown for skills from items
update scrollBar in SkillsTab to fit imbued change Clear button to X design of the other gems
|
I found a few issues. (sorry) The hover tooltip on the imbued shows the tooltip for the second gem in the socket group. Whether it be a support or an active gem. If there is no second gem, no tooltip pops up. Opening the Imbued selection then clicking away to close it, will cause the imbued select to change to the top most support, instead of reverting to the current selected gem. Related to the first two, the tooltip does not show on Import until a change is made (quality, count, new gem, etc). Then it will follow the logic above. Typing to search for the gems is different than the normal dropdowns. I can't type "spell" to have spell echo show up. With Fireball as the skill. I type s, it auto fills with Sacrifice. Then, any further letters are added onto that gem name, so "Sacrificepell". If you backspace to remove the text, once it's fully erased, backspacing again will show the hex color code. |
…lor, click away from dropdown fix
Description of the problem being solved:
Full implementation of Imbued Supports, including Importing from Character, Saving and Loading to the XML, and fixing "too many gems in slot" warning. The selection automatically filters for Level 1 Non-Exceptional Support gems. The colour of "Imbued Support:" will follow the application options Positive Values Hex colour.
You are only allowed one imbued support per Slot.
PS: This PR also removes the Variant column in the skillsTab. It happened long enough ago I forgot it was in this branch. If you don't want it in this change, let me know.
After screenshot: