Feature/trade query improvements#9688
Closed
BeardyBarber wants to merge 3 commits intoPathOfBuildingCommunity:devfrom
Closed
Feature/trade query improvements#9688BeardyBarber wants to merge 3 commits intoPathOfBuildingCommunity:devfrom
BeardyBarber wants to merge 3 commits intoPathOfBuildingCommunity:devfrom
Conversation
…ods, catalyst de-augmentation - Consolidate related explicit/implicit trade stat IDs into pseudo.* filters to reduce filter slot usage (PseudoStats.lua cache + pseudoMemberLookup) - Add "Require current mods" checkbox: adds explicit/implicit mods from the currently equipped item as required minimum filters - Strip catalyst quality boost from mod values before setting required minimums - Skip crafted (bench) mods from required filters so users can re-craft them - Fix catalyst clipboard format parsing in Item.lua - Parse and round-trip valueScalar annotation through BuildRaw - Add tests: catalyst parsing, valueScalar, de-augmentation formula, crafted skip
…dling - Fix Eldritch mods (Eater/Exarch): now properly included in require-current-mods filters for modes 2-3 by merging eldritch text lookups into explicit lookup when checkbox is enabled - Add Implicit Mods checkbox: gates implicit weight generation (modes 1-3) and implicit require-current-mods filtering (modes 2-3), giving users fine-grained control over implicit mod inclusion - Fix popup layout: shorten "Search mode:" label to "Mode:" to prevent label from extending off-screen in the TOPRIGHT-anchored control chain All checkbox behaviors now respect the four search modes: Mode 1 (Standard): weighted search Mode 2 (Upgrade): weighted + require current mods Mode 3 (Exact): require current mods only Mode 4 (Implicit Upgrade): implicit weights only Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…r, UI layout - Fix local weapon/armour mods mapping to wrong trade stat ID (preferLocal lookup) - Fix crafted mod count group using wrong data pool (data.masterMods vs data.itemMods.Item) - Fix crafted slot stat IDs: looked up dynamically from trade API, cached in PseudoStats.lua - Add Implicit Mods, Pseudo Mods checkboxes; rename Corrupted Mods → Corrupted Items - Corrupted Items now adds misc_filters exclusion same as Mirrored Items - Fix control layout: all controls left-aligned in single TOPLEFT chain, correct order Claude Code helped here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.