Fix map iteration for limitedSkills copy to apply properly#9718
Open
rasmuskl wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Fix map iteration for limitedSkills copy to apply properly#9718rasmuskl wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
rasmuskl wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Fixes an issue where characters using Blight + Blight of Contagion would stack overflow when using Maximum Sustainable Stacks.
Discovered in poe.ninja but reproduced on the build below in the desktop version by switching Blight to Maximum Sustainable Stacks.
The issue is that
ipairswill not iterate the uuids.Steps taken to verify a working solution:
Re-tested in patched desktop version + patched poe.ninja version.
Link to a build that showcases this PR:
https://poe.ninja/poe1/profile/Miyune92-0566/mirage/character/Noigatnoc_fo_Thgilb
Before screenshot:
After screenshot: