Skip to content

Use SSA proportions for SS sub-component fallback shares#603

Open
MaxGhenis wants to merge 2 commits intomainfrom
improve-ss-subcomponent-shares
Open

Use SSA proportions for SS sub-component fallback shares#603
MaxGhenis wants to merge 2 commits intomainfrom
improve-ss-subcomponent-shares

Conversation

@MaxGhenis
Copy link
Contributor

Summary

  • Replace equal-share (1/4 each) fallback in reconcile_ss_subcomponents() with SSA Fact Sheet aggregate proportions when QRF predicts all zeros for a record with positive total social security
  • Retirement ~73%, disability ~10%, survivors ~11%, dependents ~6% — matching the distribution in HARD_CODED_TOTALS from utils/loss.py
  • Add _SSA_DEFAULT_SHARES module-level dict and new test test_zero_predictions_use_ssa_shares

Test plan

  • All 22 existing tests pass (pytest policyengine_us_data/tests/test_extended_cps.py -v)
  • New test verifies fallback shares match SSA proportions (retirement > 70%)
  • test_single_component_gets_full_total still passes (only retirement nonzero case)

🤖 Generated with Claude Code

MaxGhenis and others added 2 commits March 14, 2026 07:38
Replace equal 1/4 fallback with SSA Fact Sheet aggregate
proportions (retirement ~73%, disability ~10%, survivors ~11%,
dependents ~6%) when QRF predicts all zeros for a record with
positive total social_security.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant