Skip to content

feat(code): use remote files for cloud review panel#1491

Merged
adboio merged 1 commit intomainfrom
04-03-feat_code_use_remote_files_for_cloud_review_panel
Apr 7, 2026
Merged

feat(code): use remote files for cloud review panel#1491
adboio merged 1 commit intomainfrom
04-03-feat_code_use_remote_files_for_cloud_review_panel

Conversation

@adboio
Copy link
Copy Markdown
Contributor

@adboio adboio commented Apr 3, 2026

Problem

the cloud diff review panel constructs a diff from the agent output. this is fine, but makes it harder to ensure the panel is up-to-date with remote branch or PR, which means it'd be hard to do cooler stuff with PR comments/CI/etc in the future

Changes

swaps out the cloud review panel to always use a diff from the PR or the remote branch, never constructed from agent changes

  • agent changes are still visible in realtime in the chat thread
  • changed files list in the sidebar still uses agent output for lisitng the files

How did you test this?

manually

@adboio adboio requested a review from a team April 3, 2026 17:01
@adboio adboio marked this pull request as ready for review April 3, 2026 17:03
@adboio adboio force-pushed the 04-03-feat_code_use_remote_files_for_cloud_review_panel branch from fed5f3e to 488611e Compare April 3, 2026 20:20
@adboio adboio force-pushed the 04-02-feat_code_remove_cloud_status_bar_add_pr_view_button branch from 75f8ad3 to a3bc89b Compare April 3, 2026 20:20
@adboio adboio force-pushed the 04-03-feat_code_use_remote_files_for_cloud_review_panel branch from 488611e to 3398bc6 Compare April 3, 2026 21:59
@adboio adboio force-pushed the 04-02-feat_code_remove_cloud_status_bar_add_pr_view_button branch from a3bc89b to 3618421 Compare April 3, 2026 21:59
@joshsny joshsny requested a review from tatoalo April 7, 2026 08:49
Copy link
Copy Markdown
Contributor

@k11kirky k11kirky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should take this same approuch to local tasks once a commit or pr is completed? keep consistaent. make cloud -> local easier and it fixes an issue when post commit you lose all dif for review

Copy link
Copy Markdown
Contributor Author

adboio commented Apr 7, 2026

@k11kirky yep definitely, i've prioritized cloud for now but will be taking as much of this over to local as i can!

Copy link
Copy Markdown
Contributor Author

adboio commented Apr 7, 2026

Merge activity

  • Apr 7, 3:16 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 7, 3:18 PM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 7, 3:26 PM UTC: @adboio merged this pull request with Graphite.

@adboio adboio changed the base branch from 04-02-feat_code_remove_cloud_status_bar_add_pr_view_button to graphite-base/1491 April 7, 2026 15:16
@adboio adboio changed the base branch from graphite-base/1491 to main April 7, 2026 15:16
@adboio adboio force-pushed the 04-03-feat_code_use_remote_files_for_cloud_review_panel branch from 3398bc6 to 2bafa3b Compare April 7, 2026 15:17
@adboio adboio merged commit 77fd1d7 into main Apr 7, 2026
16 checks passed
@adboio adboio deleted the 04-03-feat_code_use_remote_files_for_cloud_review_panel branch April 7, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants