Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 77 additions & 0 deletions apps/code/src/renderer/api/posthogClient.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import type {
AvailableSuggestedReviewer,
AvailableSuggestedReviewersResponse,
SandboxEnvironment,
SandboxEnvironmentInput,
SignalReport,
Expand Down Expand Up @@ -161,6 +163,50 @@ function parseSignalReportArtefactsPayload(
};
}

function normalizeAvailableSuggestedReviewer(
uuid: string,
value: unknown,
): AvailableSuggestedReviewer | null {
if (!isObjectRecord(value)) {
return null;
}

const normalizedUuid = optionalString(uuid);
if (!normalizedUuid) {
return null;
}

return {
uuid: normalizedUuid,
name: optionalString(value.name) ?? "",
email: optionalString(value.email) ?? "",
};
}

function parseAvailableSuggestedReviewersPayload(
value: unknown,
): AvailableSuggestedReviewersResponse {
if (!isObjectRecord(value)) {
return {
results: [],
count: 0,
};
}

const results = Object.entries(value)
.map(([uuid, reviewer]) =>
normalizeAvailableSuggestedReviewer(uuid, reviewer),
)
.filter(
(reviewer): reviewer is AvailableSuggestedReviewer => reviewer !== null,
);

return {
results,
count: results.length,
};
}

export class PostHogAPIClient {
private api: ReturnType<typeof createApiClient>;
private _teamId: number | null = null;
Expand Down Expand Up @@ -958,6 +1004,9 @@ export class PostHogAPIClient {
if (params?.source_product) {
url.searchParams.set("source_product", params.source_product);
}
if (params?.suggested_reviewers) {
url.searchParams.set("suggested_reviewers", params.suggested_reviewers);
}

const response = await this.api.fetcher.fetch({
method: "get",
Expand All @@ -976,6 +1025,34 @@ export class PostHogAPIClient {
};
}

async getAvailableSuggestedReviewers(
query?: string,
): Promise<AvailableSuggestedReviewersResponse> {
const teamId = await this.getTeamId();
const url = new URL(
`${this.api.baseUrl}/api/projects/${teamId}/signal_reports/available_reviewers/`,
);
const path = `/api/projects/${teamId}/signal_reports/available_reviewers/`;

if (query?.trim()) {
url.searchParams.set("query", query.trim());
}

const response = await this.api.fetcher.fetch({
method: "get",
url,
path,
});

if (!response.ok) {
throw new Error(
`Failed to fetch available suggested reviewers: ${response.statusText}`,
);
}

return parseAvailableSuggestedReviewersPayload(await response.json());
}

async getSignalReportSignals(
reportId: string,
): Promise<SignalReportSignalsResponse> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ import {
} from "@features/inbox/components/InboxEmptyStates";
import { InboxLiveRail } from "@features/inbox/components/InboxLiveRail";
import { InboxSourcesDialog } from "@features/inbox/components/InboxSourcesDialog";
import { useInboxReportsInfinite } from "@features/inbox/hooks/useInboxReports";
import {
useInboxAvailableSuggestedReviewers,
useInboxReportsInfinite,
} from "@features/inbox/hooks/useInboxReports";
import { useSignalSourceConfigs } from "@features/inbox/hooks/useSignalSourceConfigs";
import { useInboxReportSelectionStore } from "@features/inbox/stores/inboxReportSelectionStore";
import { useInboxSignalsFilterStore } from "@features/inbox/stores/inboxSignalsFilterStore";
Expand All @@ -15,6 +18,7 @@ import { useInboxSourcesDialogStore } from "@features/inbox/stores/inboxSourcesD
import {
buildSignalReportListOrdering,
buildStatusFilterParam,
buildSuggestedReviewerFilterParam,
filterReportsBySearch,
} from "@features/inbox/utils/filterReports";
import { INBOX_REFETCH_INTERVAL_MS } from "@features/inbox/utils/inboxConstants";
Expand All @@ -38,6 +42,9 @@ export function InboxSignalsTab() {
const sourceProductFilter = useInboxSignalsFilterStore(
(s) => s.sourceProductFilter,
);
const suggestedReviewerFilter = useInboxSignalsFilterStore(
(s) => s.suggestedReviewerFilter,
);

// ── Signal source configs ───────────────────────────────────────────────
const { data: signalSourceConfigs } = useSignalSourceConfigs();
Expand All @@ -64,6 +71,10 @@ export function InboxSignalsTab() {
const inboxPollingActive = windowFocused && isInboxView;

// ── Data fetching ───────────────────────────────────────────────────────
useInboxAvailableSuggestedReviewers({
enabled: isInboxView,
});

const inboxQueryParams = useMemo(
(): SignalReportsQueryParams => ({
status: buildStatusFilterParam(statusFilter),
Expand All @@ -72,8 +83,18 @@ export function InboxSignalsTab() {
sourceProductFilter.length > 0
? sourceProductFilter.join(",")
: undefined,
suggested_reviewers:
suggestedReviewerFilter.length > 0
? buildSuggestedReviewerFilterParam(suggestedReviewerFilter)
: undefined,
}),
[statusFilter, sortField, sortDirection, sourceProductFilter],
[
statusFilter,
sortField,
sortDirection,
sourceProductFilter,
suggestedReviewerFilter,
],
);

const {
Expand Down Expand Up @@ -194,7 +215,9 @@ export function InboxSignalsTab() {
// ── Layout mode (computed early — needed by focus effect below) ────────
const hasReports = allReports.length > 0;
const hasActiveFilters =
sourceProductFilter.length > 0 || statusFilter.length < 5;
sourceProductFilter.length > 0 ||
suggestedReviewerFilter.length > 0 ||
statusFilter.length < 5;
const shouldShowTwoPane =
hasReports || !!searchQuery.trim() || hasActiveFilters;

Expand Down Expand Up @@ -324,21 +347,15 @@ export function InboxSignalsTab() {
className="outline-none"
onMouseDownCapture={(e) => {
const target = e.target as HTMLElement;
if (
target.closest(
"[data-report-id], button, input, select, textarea, [role='checkbox']",
)
) {
if (target.closest("[data-report-id]")) {
focusListPane();
}
}}
onFocusCapture={(e) => {
const target = e.target as HTMLElement;
if (
target !== leftPaneRef.current &&
target.closest(
"[data-report-id], button, input, select, textarea, [role='checkbox']",
)
target.closest("[data-report-id]")
) {
focusListPane();
}
Expand Down
Loading
Loading