Skip to content

feat(inbox): Show signals report data in the detail pane#1552

Merged
sortafreel merged 6 commits intomainfrom
signals/new-report-data-in-inbox-ui-v2
Apr 8, 2026
Merged

feat(inbox): Show signals report data in the detail pane#1552
sortafreel merged 6 commits intomainfrom
signals/new-report-data-in-inbox-ui-v2

Conversation

@sortafreel
Copy link
Copy Markdown
Contributor

@sortafreel sortafreel commented Apr 8, 2026

Problem

We get plenty of data from the Signals report to:

  • Show if the issue is already addressed
  • Show what code files / SQL queries are relevant to the issue
  • Explain how we decided on priority/actionability (both for us to debug and for users to ground the logic)

But we don't show them in the UI

Changes

Surfaces researched signals data — priority, actionability, evidence — directly in the inbox detail pane, replacing the placeholder badges with typed, explainable judgments.

  • Priority and Actionability detail rows with collapsible "Why?" explanations sourced from priority_judgment / actionability_judgment artefacts
  • "Already addressed" warning banner driven by either report.already_addressed or the actionability judgment's flag
  • Per-signal evidence: SignalCards now receive a SignalFinding and surface a Verified/Unverified badge plus collapsible Relevant code and Data queried sections
  • Inbox list card: SignalReportActionabilityBadge chip alongside the existing status / priority chips
  • Typed normalizers for priority_judgment, actionability_judgment and signal_finding artefacts in posthogClient
CleanShot 2026-04-08 at 17 45 17
CleanShot 2026-04-08 at 18 01 35
image
image

Notes

How did you test this?

- Add Priority and Actionability detail rows with collapsible "Why?"
  explanations from priority_judgment and actionability_judgment artefacts
- Add 'already addressed' warning banner driven by report or judgment
- Pass per-signal SignalFinding (verified flag, code paths, data queried)
  to SignalCard so the detail pane can surface research evidence
- Add VerificationBadge to SignalCardHeader and CodePaths/DataQueried
  collapsibles inside each source-specific signal card variant
- Add SignalReportActionabilityBadge alongside the existing priority/
  status chips on the inbox list card
- Restructure the evidence section in ReportDetailPane to surface
  loading and unavailable states (forbidden, not_found, invalid_payload,
  request_failed) so the user gets feedback when artefacts can't load
- Add typed normalizers for priority_judgment, actionability_judgment
  and signal_finding artefacts in posthogClient
- Drop the legacy JudgmentBadges component, which used an outdated
  Record<string, unknown> shape that no longer matches the typed
  artefact schema in shared/types

Squashed-from: signals/new-report-data-in-inbox-ui-backup
Originally PR #1428
# Conflicts:
#	apps/code/src/renderer/api/posthogClient.ts
#	apps/code/src/renderer/features/inbox/components/list/ReportCard.tsx
…ta-in-inbox-ui-v2

# Conflicts:
#	apps/code/src/renderer/api/posthogClient.ts
…ta-in-inbox-ui-v2

# Conflicts:
#	apps/code/src/renderer/api/posthogClient.ts
@adboio adboio self-requested a review April 8, 2026 15:22
@adboio adboio self-assigned this Apr 8, 2026
Copy link
Copy Markdown
Contributor

@adboio adboio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sortafreel do you mind sharing screenshot(s) of the affected areas so i know specifically which pieces to review?

ty!!! ❤️

@sortafreel sortafreel changed the title feat(inbox): show signals report data in detail pane feat(inbox): Show signals report data in detail pane Apr 8, 2026
@sortafreel sortafreel changed the title feat(inbox): Show signals report data in detail pane feat(inbox): Show signals report data in the detail pane Apr 8, 2026
@sortafreel sortafreel requested a review from a team April 8, 2026 16:10
Copy link
Copy Markdown
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green light

@sortafreel sortafreel merged commit 316d23e into main Apr 8, 2026
15 checks passed
@sortafreel sortafreel deleted the signals/new-report-data-in-inbox-ui-v2 branch April 8, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants