chore(code): github branch picker loading all branches#1592
Open
VojtechBartos wants to merge 5 commits intomainfrom
Open
chore(code): github branch picker loading all branches#1592VojtechBartos wants to merge 5 commits intomainfrom
VojtechBartos wants to merge 5 commits intomainfrom
Conversation
a42284e to
9c24c33
Compare
Contributor
|
i don't think it's your fault haha i'm just curious - where is that latency coming from? looked like at least a few seconds before we got the first page of results - is that posthog api or github api taking so long? can be a followup, but if there's no way around that, we should consider some local caching here so it's snappier most of the time |
adboio
reviewed
Apr 9, 2026
| ); | ||
|
|
||
| // Auto-fetch remaining pages in background once the first page arrives | ||
| useEffect(() => { |
Contributor
There was a problem hiding this comment.
can we abort this query once the user selects a branch?
or if we keep this and fetch everything even after the user is done, we should at least be caching the results (see global comment)
Member
Author
|
@adboio soooo :) ...
the changes i have made
WDYT? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The branches API was capped at 2000 branches. Repositories with more than that were missing branches in the selector.
Changes
Prerequisite
Posthog API changes PostHog/posthog#53931
Showcase
code-paginating.branches.mov