feat(inbox): Shift+Arrow keyboard selection for reports#1608
Open
posthog[bot] wants to merge 1 commit intomainfrom
Open
feat(inbox): Shift+Arrow keyboard selection for reports#1608posthog[bot] wants to merge 1 commit intomainfrom
posthog[bot] wants to merge 1 commit intomainfrom
Conversation
Arrow Up/Down now extends selection when Shift is held, following the standard desktop pattern (Finder, Mail.app). A new `selectExactRange` store method replaces (rather than merges) the selection so that reversing direction correctly contracts the range. Generated-By: PostHog Code Task-Id: c0bd48e9-c803-4835-8e1d-a18797660c05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selectExactRangestore method that replaces (not merges) the selection, so reversing direction correctly contracts the rangeTest plan
pnpm --filter code testCreated with PostHog Code