Add end-to-end test for make pgxntool-sync#6
Open
jnasbyupgrade wants to merge 1 commit intoPostgres-Extensions:masterfrom
Open
Add end-to-end test for make pgxntool-sync#6jnasbyupgrade wants to merge 1 commit intoPostgres-Extensions:masterfrom
jnasbyupgrade wants to merge 1 commit intoPostgres-Extensions:masterfrom
Conversation
New test (test/standard/pgxntool-sync.bats) validates the full `make pgxntool-sync` flow: git subtree pull → update-setup-files.sh. Creates a dedicated source repo with two tagged versions to guarantee git subtree add is used (vs rsync fallback for dirty repos). Verifies subtree pull succeeds, .gitignore is auto-updated by update-setup-files.sh, and the merge commit is created correctly. Document BATS `set -eET` behavior in test/CLAUDE.md: errexit is active in all test functions including setup_file, subshell failures propagate, and `local var=$(cmd)` masks exit status. Improve commit command allowed-tools to use broader glob patterns, reducing per-command approval prompts. Changes only in pgxntool-test. No related changes in pgxntool. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make pgxntool-syncflow (git subtree pull→update-setup-files.sh)git subtree addis used (vs rsync fallback for dirty repos).gitignoreis auto-updated byupdate-setup-files.sh, and merge commit is created correctlyset -eETerror handling behavior intest/CLAUDE.mdTest plan
test/bats/bin/bats test/standard/pgxntool-sync.bats— all 6 tests passmake test— full suite passes (157 tests, no regressions)No related changes in pgxntool.