(#208) Improve UX of Crescendo cmdlets#209
Open
steviecoaster wants to merge 1 commit intoPowerShell:masterfrom
Open
(#208) Improve UX of Crescendo cmdlets#209steviecoaster wants to merge 1 commit intoPowerShell:masterfrom
steviecoaster wants to merge 1 commit intoPowerShell:masterfrom
Conversation
This commit improves the author experience when accelerating a native command. This commit exposes all class properties as function parameters. Where appropriate an argumentcompleter attribute has been introduced to further enhance the authoring experience when working with the Microsoft.PowerShell.Crescendo module.
Contributor
|
@steviecoaster - Thanks for this, I certainly think it will be helpful. Would it be too much to ask to have some validation for the new behavior? I'm reluctant to take anything that doesn't improve the validation. |
Author
|
@JamesWTruher I can add some tests for this behavior, certainly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request enhances the user experience of the Microsoft.PowerShell.Crescendo module by exposing all available class properties as cmdlet parameters for the respective Cmdlet
PR Context
Creating Crescendo objects with the Microsoft.PowerShell.Crescendo module today requires the user to write extra glue code to fully extend the Crescendo object before generating the json schema for the module.
This friction is reduced by adding all available properties as Cmdlet parameters, reducing the amount of glue code required on the part of the end user.
Fixes #208