Skip to content

Minor improvements for signalprocessing.Interp and signalprocessing.InterpCubicSpline#743

Open
MothNik wants to merge 10 commits intoPyLops:devfrom
MothNik:dev
Open

Minor improvements for signalprocessing.Interp and signalprocessing.InterpCubicSpline#743
MothNik wants to merge 10 commits intoPyLops:devfrom
MothNik:dev

Conversation

@MothNik
Copy link
Copy Markdown
Contributor

@MothNik MothNik commented Apr 5, 2026

This pull request provides minor improvements for

  • signalprocessing.Interp
    1. fixed potential silent mutation of iava input
    2. fixed typo in docstring
    3. fixed missing cubic_spline in Raises
  • signalprocessing.InterpCubicSpline
    1. fixed typo in auxiliary class docstring
    2. fixed bad index in _rmatvec that was silently caught by numpy slicing operations preventing out of bound slicing

Besides, a dedicated dottest test was added for signalprocessing.InterpCubicSpline (adds to the only indirect dottest tests for signalprocessing.Interp(..., kind="cubic_spline").
Also, a test for boundary conditions (bc_type) that are not supported is added to make sure that signalprocessing.InterpCubicSpline raises a NotImplementedError.

MothNik added 10 commits April 5, 2026 16:45
`signalprocessing.interpspline`
- fixed duplicated error message
`signalprocessing.interp`
- fixed missisng `cubic_spline` in docstring on errors
`signalprocessing.interp`
- fixed typo in docstring
`signalprocessing.interpspline`
- fixed bad slicing that was clipped internally by `numpy` and thus took
  no effect
`signalprocessing.interpspline`
- fixed typo in docstring
`signalprocessing._interp_utils`
- fixed silent mutation of `iava`
`signalprocessing._interp_utils`
- fixed behaviour of `iava` not being returned after copying to avoid
  mutation
`test.test_interpolation_spline`
- added explicit `dottest` for spline
`signalprocessing._interp_utils`
- added clarifying comment on silent mutation of `iava`
`test_interpolation_spline`
- added test for boundary conditions that are not supported
@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@mrava87SW
Copy link
Copy Markdown

@MothNik saw this, will take a look in the next couple of days 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants