Minor improvements for signalprocessing.Interp and signalprocessing.InterpCubicSpline#743
Open
MothNik wants to merge 10 commits intoPyLops:devfrom
Open
Minor improvements for signalprocessing.Interp and signalprocessing.InterpCubicSpline#743MothNik wants to merge 10 commits intoPyLops:devfrom
signalprocessing.Interp and signalprocessing.InterpCubicSpline#743MothNik wants to merge 10 commits intoPyLops:devfrom
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
|
@MothNik saw this, will take a look in the next couple of days 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request provides minor improvements for
signalprocessing.Interpiavainputcubic_splineinRaisessignalprocessing.InterpCubicSpline_rmatvecthat was silently caught bynumpyslicing operations preventing out of bound slicingBesides, a dedicated
dottesttest was added forsignalprocessing.InterpCubicSpline(adds to the only indirectdottesttests forsignalprocessing.Interp(..., kind="cubic_spline").Also, a test for boundary conditions (
bc_type) that are not supported is added to make sure thatsignalprocessing.InterpCubicSplineraises aNotImplementedError.