Conversation
| run_step "contracts-bedrock tests setup (go-ffi)" just build-go-ffi | ||
|
|
||
| # temporarily skip failed tests that block CI process | ||
| SKIP_PATH="test/universal/OptimismMintableERC20Factory.t.sol" |
There was a problem hiding this comment.
This case can pass when running on its own.
|
Why are these tests removed:
Are they covered elsewhere? |
|
What's your criteria to including jobs into this script? |
Generally all tests in the main workflow that validate functional correctness (unit, integration, E2E, and fuzz tests) are included.
|
|
Can we further simplify this script by calling makefile targets and justfile recipes directly? |
|
A comment to |
See comments above every |
|
|
||
| # full go tests (from .circleci/continue/main.yml go-tests-full -> go-tests-ci) | ||
| # Run at the end since this suite is the most failure-prone. | ||
| run_step "go tests full (go-tests-ci)" bash -c "TEST_TIMEOUT=90m make go-tests-ci" |
There was a problem hiding this comment.
Potential issue: dev-test.sh used to run just -f op-deployer/justfile copy-contract-artifacts immediately after the contracts-bedrock build, before the later Go test steps, but that block is gone now.
Since the script still ends with make go-tests-ci and that suite includes op-deployer packages/tests, this seems to make dt depend on a previously generated local op-deployer/pkg/deployer/artifacts/forge-artifacts/artifacts.tzst (which is .gitignored). That may work on a reused dev machine, but fail on a clean checkout.
Could we restore the copy step in its old location, or document that dt expects the embedded artifact bundle to already exist?
| fi | ||
| fi | ||
|
|
||
| command -v m4 >/dev/null 2>&1 || install_system_package m4 |
There was a problem hiding this comment.
Small setup gap: dev-test-setup.sh installs m4, clang, docker, cargo-binstall, and cargo-nextest, but it does not install zstd. dev-test.sh later runs tar --zstd -xvf during the kona host/client offline step, so mise run dt-setup && mise run dt can still fail on a clean machine.
Could we add zstd to the setup script as well, so the documented one-time setup actually covers all required runtime dependencies?
3 participants
Test script update based on the v1.16.8 merge.
Successfully ran on AX101: Execution time: 61 minute(s) and 54 second(s)