make rspirv dep a workspace git dep instead of a patch#2
Open
Firestar99 wants to merge 1 commit intoRust-GPU:mainfrom
Open
make rspirv dep a workspace git dep instead of a patch#2Firestar99 wants to merge 1 commit intoRust-GPU:mainfrom
Firestar99 wants to merge 1 commit intoRust-GPU:mainfrom
Conversation
Firestar99
added a commit
to Rust-GPU/rust-gpu
that referenced
this pull request
Feb 18, 2026
…git dep instead of a patch Rust-GPU/SPIRV-Tools#2
Firestar99
added a commit
to Rust-GPU/rust-gpu
that referenced
this pull request
Feb 18, 2026
…git dep instead of a patch Rust-GPU/SPIRV-Tools#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@LegNeato don't have push perms on the repo...
If you declare rspirv git rev as a patch, any other project (like rust-gpu) depending on this project as a git dependency will use rspirv from crates. But if you declare rspirv directly as a git dependency, rust-gpu will also use said git dependency instead of needing to patch rspirv itself. Now rust-gpu also uses rspirv internally, so it will need to patch regardless, but other projects that don't interface with rspirv directly will get the benefit, like anyone using rust-gpu.