fix(aaudio): Wait for AAudioStream status change#1125
Merged
roderickvd merged 2 commits intoRustAudio:masterfrom Mar 18, 2026
Merged
fix(aaudio): Wait for AAudioStream status change#1125roderickvd merged 2 commits intoRustAudio:masterfrom
roderickvd merged 2 commits intoRustAudio:masterfrom
Conversation
roderickvd
reviewed
Mar 16, 2026
osoftware
force-pushed
the
master
branch
2 times, most recently
from
5f05ee3 to
b420553
Compare
Member
|
Thanks! Merging. |
Member
|
@osoftware By the way and off-topic to this PR but since you're an AAudio user, can you confirm the dynamic tuning has been working well for you? (#1080 with AAudio defaulting to |
Contributor
Author
|
I've just tried it on https://github.com/osoftware/rush_audio and it works fine 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs at once.
After starting the stream and before the status changes to
Started, dropping it causes the main thread to lock permanently. The underlyingAAudioStreamnever closes while thedropmethod waits for it to close. By usingwait_for_state_changemethod we ensure theplaymethod won't return befor it's safe to drop the stream.If
wait_for_state_changeis never called thenAAudioStream_getTimestampalways returnsInvalidStateerror leading toinfo.timestamp().captureandinfo.timestamp().playbackin stream callbacks always returning zero.