Draft
Conversation
Fannon
commented
Dec 10, 2025
| - "cds.LargeString" | ||
| - "cds.Integer" | ||
| - "cds.Integer64" | ||
| - "cds.Integer16" |
Member
Author
There was a problem hiding this comment.
TODO: Is this Int16 (CAP) or Integer16, consistent with existing Integer64?
Member
Author
There was a problem hiding this comment.
Suggested change
| - "cds.Integer16" | |
| - "cds.Int16" |
Fannon
commented
Dec 10, 2025
| @@ -554,6 +555,8 @@ definitions: | |||
| - "cds.LargeString" | |||
| - "cds.Integer" | |||
| - "cds.Integer64" | |||
Member
Author
There was a problem hiding this comment.
TODO: Clarify - should this have been cds.Int64 ? Then we can also go with cds.Int16.
Then we'd be consistent with https://cap.cloud.sap/docs/guides/domain-modeling#standard-built-in-types
Member
Author
|
We confirmed that We can also not introduce this PR change without FIRST:
Only after the ecosystem is ready for the new types, we should merge and release this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
cds.Integer16type (signed integer with 16 bit)cds.UInt8type (unsigned integer with 8 bit)TODO
Int16vsInteger16?Integer64toInt64for CAP CDS Type consistency?