Skip to content

Adding UInt8 and Integer16 CDS types (WIP)#124

Draft
Fannon wants to merge 4 commits intomainfrom
add-uint8-and-integer16-types
Draft

Adding UInt8 and Integer16 CDS types (WIP)#124
Fannon wants to merge 4 commits intomainfrom
add-uint8-and-integer16-types

Conversation

@Fannon
Copy link
Member

@Fannon Fannon commented Dec 10, 2025

Added

  • Added cds.Integer16 type (signed integer with 16 bit)
  • Added cds.UInt8 type (unsigned integer with 8 bit)

TODO

  • Also add this in the existing two type mappings
  • Follow up task: Create HANA mapping ?
  • Clarify: Int16 vs Integer16?
  • Clarify: Should we breaking change rename Integer64 to Int64 for CAP CDS Type consistency?

@Fannon Fannon self-assigned this Dec 10, 2025
- "cds.LargeString"
- "cds.Integer"
- "cds.Integer64"
- "cds.Integer16"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Is this Int16 (CAP) or Integer16, consistent with existing Integer64?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "cds.Integer16"
- "cds.Int16"

@@ -554,6 +555,8 @@ definitions:
- "cds.LargeString"
- "cds.Integer"
- "cds.Integer64"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Clarify - should this have been cds.Int64 ? Then we can also go with cds.Int16.

Then we'd be consistent with https://cap.cloud.sap/docs/guides/domain-modeling#standard-built-in-types

@Fannon Fannon requested a review from maiargu December 10, 2025 16:19
@Fannon
Copy link
Member Author

Fannon commented Dec 17, 2025

We confirmed that Integer64 is already in use we cannot just drop it. In best case we have to deprecate it, but keep it.

We can also not introduce this PR change without FIRST:

  • Define the mappings
  • Ecosystem supports the new mappings

Only after the ecosystem is ready for the new types, we should merge and release this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant