fix: address adversarial review findings on metrics/telemetry archite…#80
Merged
fix: address adversarial review findings on metrics/telemetry archite…#80
Conversation
…cture (#17) - Add ClusterApi.clusterUuid across all ES versions (6/7/8/9) so telemetry uses the real ES cluster UUID instead of the cluster name as identifier - Make TelemetryCollector thread-safe with synchronized lock for gauge fields and add collectAndReset for atomic snapshot+reset - Make MetricsCollector.resetMetrics atomic via AtomicReference map swap, add collectAndResetAggregatedMetrics to MetricsApi trait - Replace synchronized+set() with pure CAS and @tailrec in LicenseRefreshStrategyFactory, remove try/catch fallback (let SPI failures propagate) - Add ClusterApiSpec integration tests for clusterName and clusterUuid - Add TelemetryCollectorSpec test for collectAndReset Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cture (#17)