Skip to content

Conversation

@csanchezdll
Copy link

trace-config event is deprecated and prints an ugly error message, recommending using pre-enable and similar events, for SWO/TPIU. Even if this was not the case, I think this event is not at the right place because access to TPIU registers in COMMAND_HANDLER(handle_arm_tpiu_swo_enable) is done before the event callback is ignored, and TPIU is not clocked without TRACE_EN so the accesses fail. I discovered this while trying to use SWO in my STH32H5x custom board. The right way is to use a pre-event when configuring swo, so either removing this callback definition altogether (as his PR does) or including swo configuration i this file (as sstm32h7x.cfg does).

mem2array is deprecated and returns no value. This means the read-modify-write logic in stm32h5x_mmw does not work. This is only used in two places where reset value is zero, so no real harm is done, but it breaks other potential uses of stm32h5x_mmw (including the ones which were on the trace-config, if it was working). This PR changes it to use read_memory, which is current.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant