fix: eliminate SW session race causing initial media 401s#565
Closed
Just-Insane wants to merge 1 commit intoSableClient:devfrom
Closed
fix: eliminate SW session race causing initial media 401s#565Just-Insane wants to merge 1 commit intoSableClient:devfrom
Just-Insane wants to merge 1 commit intoSableClient:devfrom
Conversation
Resolve stash conflict in DevelopTools.tsx — keep the improved Rotate Encryption Sessions description and success message text from the stashed changes. Add an immediate synchronous sendSessionToSW() call in index.tsx before React mounts. When the SW is already active (normal page reload), navigator.serviceWorker.controller is set and the postMessage is sent before createRoot().render() runs and before any <img> elements fire fetch events. This discards the stale preloadedSession in the SW (which could be from a previous token that is no longer current) before the first thumbnail/media fetches arrive, preventing the race condition that produced 401 errors on initial load with Retry buttons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #548 — the SW session race fix has been merged into that PR.",