fix: recover profile and avatar loading#566
Merged
7w1 merged 6 commits intoSableClient:devfrom Mar 28, 2026
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bf89a08 to
724b45f
Compare
7w1
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes profile and avatar loading regressions introduced around the MSC4440 bio compatibility work.
This PR addresses two related problems:
useUserProfileencounteredgay.fomx.biographyin an unexpected shape or when the field was missing entirely.The fix does three things:
gay.fomx.biographydefensively with optional access instead of assumingm.text[0].bodyalways exists_fetched-only state after normalization failedsrcchanges so transient media/auth failures can recover on later rendersThis was verified against the broken Account settings / account switcher behavior where avatar, banner, bio, status, and pronouns could appear missing.
Fixup of #559
Type of change
Checklist:
AI disclosure:
useUserProfile.ts: Hardened MSC4440 bio parsing so missing or malformedgay.fomx.biographydata does not throw during normalization, and allowed refetching when the profile cache only contains_fetched: truefrom a prior failed normalization.UserAvatar.tsxandRoomAvatar.tsx: Reset local image error state whensrcchanges so a temporary image load failure does not permanently lock the component into fallback rendering.