Skip to content

Ping Protection V2#187

Open
Kevinking500 wants to merge 1 commit intoScootKit:mainfrom
Kevinking500:ping-protection-v2
Open

Ping Protection V2#187
Kevinking500 wants to merge 1 commit intoScootKit:mainfrom
Kevinking500:ping-protection-v2

Conversation

@Kevinking500
Copy link
Copy Markdown
Contributor

Ping Protection V2: QoL changes, multiple bug fixes, and a new user panel rewritten from scratch

Ping protection V2 was due for a bit of time, and it comes with multiple new (QoL) features/changes, multiple bug fixes and more. Due to the rewrite of the user panel being way more extensive, the lines of code have raised by quite the bit in some files (while some lowered). I've tried to keep the code as readable as possible in the meantime.

Full changelog:

  • [Bug fix] The action log message is now properly hidden if action logging is disabled for the moderation action
  • [Bug fix] A small capitalization mistake in the code likely made the 'deleteAllPingHistoryAfterTimeframe' do nothing - this has been fixed
  • [Bug fix] The channel types were not set properly in the config causing users to be able to select even voice channels - this has been limited to text, news and categories. Categories are now thus also supported per this support thread by Seppe, which automatically whitelists all (new) channels inside that category, thought due to AutoMod restrictions, AutoMod won't work with categories.
  • [New feature] Moderation actions can now have role-based ping limits, which could provide benefits to special roles like VIP with higher thresholds before getting punished.
  • [New feature] Categories are now supported (view the category bug fix)
  • [New feature] Link to the documentation is now provided with the error message when punishing fails (Note: The updated docs PR needs to be merged and published first to make it actually useful)
  • [QoL change] Some empty catch blocks have been updated to log the errors that are useful for debugging and is better to have logged than silently fail
  • [QoL change] The user panel has been completely reworked from scratch, including a new dropdown navigation menu instead of buttons, and more about data deletions below
  • [QoL change] Data deletions are now on a seperate page because of the change above, which also introduces a system like the staff management data deletion system: You can now select individual data to delete. Additionally, a cooldown system has been implemented here, with a 24h cooldown for a specific data deletion, and a 168h (1 week) cooldown for a full data deletion - this is to prevent abuse in data deletion, and this cooldown is user-specific

And that's PP v2!
Note: because this is on a seperate branch from the Staff Management module, which has not been merged yet, one of these 2 have to be merged first, then I can merge the new changes in one of these two, and then the last one can be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant