Skip to content

Fix app config file watching on Windows#6877

Draft
nickwesselman wants to merge 1 commit intomainfrom
fix-windows-toml-file-watching
Draft

Fix app config file watching on Windows#6877
nickwesselman wants to merge 1 commit intomainfrom
fix-windows-toml-file-watching

Conversation

@nickwesselman
Copy link
Contributor

Summary

  • shopify app dev was not detecting changes to shopify.app.toml on Windows
  • Chokidar delivers paths with backslashes on Windows (C:\project\shopify.app.toml) but the app configuration stores paths with forward slashes (C:/project/shopify.app.toml)
  • The raw string comparison (path === this.app.configuration.path) silently failed on Windows
  • Fixed by using normalizePath() on both sides of the comparison in handleFileEvent and handleEventForExtension

Test plan

  • Added test simulating Windows backslash paths from chokidar
  • Existing tests still pass
  • Snap release and verify on Windows that shopify.app.toml changes are picked up during shopify app dev

🤖 Generated with Claude Code

@nickwesselman
Copy link
Contributor Author

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @nickwesselman! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260220191904

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2026

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.9% 14553/18445
🟡 Branches 73.23% 7223/9863
🟡 Functions 79.09% 3704/4683
🟡 Lines 79.25% 13760/17363

Test suite run success

3773 tests passing in 1453 suites.

Report generated by 🧪jest coverage report action from 22c51c4

Chokidar delivers paths with backslashes on Windows, but the app
configuration stores paths with forward slashes. The raw string
comparison caused config changes to be silently ignored on Windows.
Use normalizePath on both sides of the comparison to ensure consistent
slash direction across platforms.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@nickwesselman nickwesselman force-pushed the fix-windows-toml-file-watching branch from a660923 to 22c51c4 Compare February 20, 2026 19:25
@nickwesselman
Copy link
Contributor Author

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @nickwesselman! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260220192627

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant