Skip to content

Upgrade TypeScript to 5.9.3#6897

Open
gonzaloriestra wants to merge 1 commit intomainfrom
upgrade-ts
Open

Upgrade TypeScript to 5.9.3#6897
gonzaloriestra wants to merge 1 commit intomainfrom
upgrade-ts

Conversation

@gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Feb 26, 2026 •
edited
Loading

WHY are these changes introduced?

Dependabot was not able to properly upgrade TS in #6887

WHAT is this pull request doing?

Upgrade TypeScript and fix some issues

How to test your changes?

CI

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2026

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements 78.79% 14500/18403
🟡 Branches 73.11% 7209/9860
🟡 Functions 79.01% 3688/4668
🟡 Lines 79.13% 13708/17323

Test suite run success

3774 tests passing in 1448 suites.

Report generated by 🧪jest coverage report action from 19007bd

gonzaloriestra
gonzaloriestra commented Feb 26, 2026
View reviewed changes
packages/app/src/cli/services/bulk-operations/stage-file.ts
}

form.append('file', new Blob([fileContents], {type: 'text/jsonl'}), filename)
form.append('file', new Blob([new Uint8Array(fileContents)], {type: 'text/jsonl'}), filename)
Copy link
Contributor Author

@gonzaloriestra gonzaloriestra Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeScript 5.9 no longer accepts Buffer as a valid BlobPart. Wrapping in new Uint8Array() satisfies the stricter type check with no runtime cost, since Buffer extends Uint8Array.

@gonzaloriestra gonzaloriestra marked this pull request as ready for review February 26, 2026 16:32
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner February 26, 2026 16:32
@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2026

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@binks-code-reviewer
Copy link

binks-code-reviewer bot commented Feb 26, 2026

🤖 Code Review · #projects-dev-ai for questions
React with 👍/👎 or reply — all feedback helps improve the agent.

✅ Complete - No issues

📋 History

✅ No issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isaacroldan isaacroldan isaacroldan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gonzaloriestra @isaacroldan