Update spec transform logic for extensions

[ryancbahan]

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[ryancbahan]

• Migrate webhook_subscription spec to direct transform parameters #6915
• Migrate privacy_compliance_webhooks to deployConfig + direct transforms #6914
• Migrate app_proxy spec to deployConfig + transformRemoteToLocal #6913
• Migrate app_access spec to deployConfig + transformRemoteToLocal #6912
• Migrate app_home spec to deployConfig + transformRemoteToLocal #6911
• Migrate branding spec to deployConfig + transformRemoteToLocal #6910
• Migrate point_of_sale spec to deployConfig + transformRemoteToLocal #6909
• Update spec transform logic for extensions #6908 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	78.81%	14514/18417
🟡	Branches	73.16%	7221/9870
🟡	Functions	79.01%	3690/4670
🟡	Lines	79.15%	13721/17336

Test suite run success

3781 tests passing in 1449 suites.

Report generated by 🧪jest coverage report action from 8b9720e

[github-actions]

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

[binks-code-reviewer]

transformRemoteToLocal is now always set even when transformConfig is omitted

createConfigExtensionSpecification now computes const transformRemoteToLocal = spec.transformRemoteToLocal ?? resolveReverseAppConfigTransform(spec.schema, spec.transformConfig) and resolveReverseAppConfigTransform returns a default reverse-transform when transformConfig is undefined. This means every config extension spec will have a reverse transform unless it explicitly sets transformRemoteToLocal: undefined (not really expressible) or bypasses the factory. Previously, transformConfig was required, so the behavior was explicit.

Why this is risky: callers relying on “no reverse transform” semantics may see keys dropped, content nested according to schema, or input mutation (see next comment), leading to confusing diffs or broken local config; and potentially omitting server fields if the transformed output is re-sent.

Scale: affects any configuration extension spec created without transformConfig (now allowed by types).

[binks-code-reviewer]

🤖 Code Review · #projects-dev-ai for questions
React with 👍/👎 or reply — all feedback helps improve the agent.

✅ Complete - 1 findings

📋 History

✅ 1 findings