Read client steps from remote config

[alfonso-noriega]

WHY are these changes introduced?

Extension specifications need to include client steps information to support build processes that require step-by-step client-side operations.

WHAT is this pull request doing?

• Adds clientSteps field to the GraphQL query for fetching extension specifications
• Updates the RemoteSpecification interface to include a clientSteps property of type ClientSteps
• Implements parsing logic in AppManagementClient to convert the string-based clientSteps field from the API response into a structured ClientSteps array
• Imports the ClientSteps type from the build services module

How to test your changes?

1. Run the application and trigger a fetch of extension specifications
2. Verify that the clientSteps field is properly retrieved from the GraphQL API
3. Confirm that the client steps are correctly parsed and available in the specification objects

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[alfonso-noriega]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Refactor extension build process to use modular build steps #6867 : 2 dependent PRs (#6868 , #6869 )
• Read client steps from remote config #6941 👈 (View in Graphite)
• Add client steps implementation to support existing functionalities #6966
• Create abstract client steps infrastracture to externalize the ap modules client configurations #6965
• Clean up module outputFile calculation and move it to the specifications #6967
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	78.75%	14572/18505
🟡	Branches	72.99%	7246/9927
🟡	Functions	78.95%	3714/4704
🟡	Lines	79.09%	13768/17407

Test suite run success

3814 tests passing in 1458 suites.

Report generated by 🧪jest coverage report action from d695822

[binks-code-reviewer]

Unhandled JSON.parse can crash specifications fetch

clientSteps is sourced from a remote API field (spec.clientSteps) and is parsed with JSON.parse without a try/catch. If the API returns invalid JSON (e.g., empty string, partially-written JSON, a plain string, or an unexpectedly formatted value), JSON.parse will throw and the entire specifications() call will reject.

Evidence:

function parseClientSteps(clientSteps: string | null | undefined): ClientSteps | undefined {
  if (!clientSteps) return undefined
  return JSON.parse(clientSteps)
}

This can make the CLI fail to fetch extension specifications, potentially breaking deploy/build flows for users receiving malformed clientSteps (or during a transient backend bug).

[binks-code-reviewer]

🤖 Code Review · #projects-dev-ai for questions
React with 👍/👎 or reply — all feedback helps improve the agent.

✅ Complete - 1 findings

📋 History

✅ 1 findings

[ryancbahan]

I am worried about the coupling of client <> server we're doing here and the implications it has.