Fix disappearing cards in masonry when optimizeItemArrangement is dis…#2104
Open
j0sip wants to merge 2 commits intoShopify:mainfrom
Open
Fix disappearing cards in masonry when optimizeItemArrangement is dis…#2104j0sip wants to merge 2 commits intoShopify:mainfrom
j0sip wants to merge 2 commits intoShopify:mainfrom
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes (issue #2103)
This PR fixes an issue in masonry layout where cards unexpectedly disappear as user scrolls when
optimizeItemArrangementis disabled.It adds a new arrays of sorted layout indices to MasonryLayoutManager, which enables correct binary search when calculating visible items. Current implementation of binary search fails when
optimizeItemArrangementis disabled, because the array of layouts is not sorted by y position. This leads to incorrect results when column heights are different.The fix only affects masonry layout and only when
optimizeItemArrangement === false, since the issue is not occurring when the prop is enabled.Reviewers’ hat-rack 🎩
Screenshots or videos (if needed)
Video (after disabling optimizeItemArrangement in ComplexMasonry from fixture app:
flashlist-fix.mp4