feat(install): add proxy-aware HTTPS agent while downloading pre-built binaries#3694
Open
rohit-mondal-17 wants to merge 1 commit intoShopify:mainfrom
Open
feat(install): add proxy-aware HTTPS agent while downloading pre-built binaries#3694rohit-mondal-17 wants to merge 1 commit intoShopify:mainfrom
rohit-mondal-17 wants to merge 1 commit intoShopify:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background & Motivation
This PR solves the proxy routing problem (and keeps TLS validation intact). It does not change checksum verification, tar extraction, or the file layout.
What’s Changed (Implementation)
Proxy Agent (optional)
Robust redirect handling
Request guardrails
Security Considerations
Test Plan (local & CI)
Open Internet (baseline)
yarn install (or npm install) should:
Proxied Network (Squid or equivalent)
Export proxy env vars and (optionally) a corporate CA:
export HTTPS_PROXY='http://<proxy-host>:<port>' export HTTP_PROXY=$HTTPS_PROXY export ALL_PROXY=$HTTPS_PROXY export NODE_EXTRA_CA_CERTS=/path/to/corporate-root-ca.pemEnsure https-proxy-agent is present (consumer installs it; the script dynamically imports it).
yarn install should succeed; binaries download via CONNECT tunneling.
Redirect Handling
Manually test a URL with a known redirect (e.g., release asset short links) to verify relative/absolute Location headers are handled with the same agent.