Skip to content

[Customer account UI extensions 2026-01]: Improved descriptions for "Feedback and status indicators" components#4261

Merged
mcvinci merged 1 commit into2026-01from
customer-accounts-feedback-and-status-indicators-2026-01
Apr 6, 2026
Merged

[Customer account UI extensions 2026-01]: Improved descriptions for "Feedback and status indicators" components#4261
mcvinci merged 1 commit into2026-01from
customer-accounts-feedback-and-status-indicators-2026-01

Conversation

@mcvinci
Copy link
Copy Markdown
Contributor

@mcvinci mcvinci commented Apr 3, 2026

This PR:

  • Improves JSDoc descriptions for checkout Feedback and Status Indicator components (Announcement, Badge, Banner, Progress, Spinner) to align with admin UI extensions documentation style — clearer opening sentences, bulleted value descriptions for enum props, and inline "Learn more about" links replacing @see tags.
  • Adds missing descriptions for ToggleState, ToggleArgumentsEvent, ReducedIconTypes, and the dismiss() method on Announcement, ensuring all public types and methods are documented.
  • Updated components-shared.d.ts to keep upstream descriptions consistent with the component-level overrides, removing internal @implementation annotations and vague phrasing like "Adjusts the size" or "Modify the color."
  • Relates to https://github.com/shop/world/pull/577654
  • Partially closes https://github.com/shop/issues-learn/issues/1494

@mcvinci mcvinci self-assigned this Apr 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

🚨🚨🚨 Docs migration in progress 🚨🚨🚨

We are actively migrating UI extension reference docs to MDX in the areas/platforms/shopify-dev zone of the monorepo. This impacts docs for the following surfaces:

During this migration, please be aware of the following:

.doc.ts files are being deprecated. Changes to .doc.ts files in this repo will not be reflected in the new MDX-based docs. If you need to update docs for a reference that has already been migrated, make your changes directly in the areas/platforms/shopify-dev zone of the monorepo instead.

Doc comments in .ts source files (the comment blocks above types and functions) are also affected. Generating docs from these comments currently requires a newer version of the @shopify/generate-docs library that isn't yet available. Updates to doc comments may not produce the expected output until the migration is complete.

Examples that previously lived in this repo are being moved to the areas/platforms/shopify-dev zone of the monorepo and should be authored there going forward.

What should I do?

  • If your PR includes changes to .doc.ts files, doc comments, or examples, please reach out to us in #devtools-proj-templated-refs so we can help ensure your updates are captured correctly.
  • If your PR is limited to source code changes (non-docs), you can ignore this notice.

Thanks for your patience while we complete the migration! 🙏

@mcvinci mcvinci added documentation Improvements or additions to documentation Customer account UI extensions #gsd:49303 Shopify Dev Docs: UI Extension Reference Docs: Quality & Completeness labels Apr 3, 2026
@mcvinci mcvinci force-pushed the customer-accounts-feedback-and-status-indicators-2026-01 branch from ce0356c to 44f7f9e Compare April 3, 2026 18:22
@mcvinci mcvinci marked this pull request as ready for review April 3, 2026 18:55
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset directory. If the changes are user-facing and should cause a version bump, run yarn changeset to track your changes and include them in the next release CHANGELOG. If you are making simple updates to repo configuration, examples, or documentation, you do not need to add a changeset.

@mcvinci mcvinci requested a review from sordaz00 April 3, 2026 19:48
Copy link
Copy Markdown
Contributor

@sordaz00 sordaz00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Same comment.

@mcvinci mcvinci merged commit d0b5fad into 2026-01 Apr 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Customer account UI extensions documentation Improvements or additions to documentation #gsd:49303 Shopify Dev Docs: UI Extension Reference Docs: Quality & Completeness

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants