Add building and container recipes#26
Closed
aaronsch0 wants to merge 1 commit intoSimulation-Software-Engineering:mainfrom
Closed
Add building and container recipes#26aaronsch0 wants to merge 1 commit intoSimulation-Software-Engineering:mainfrom
aaronsch0 wants to merge 1 commit intoSimulation-Software-Engineering:mainfrom
Conversation
MakisH
reviewed
Apr 11, 2026
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Everything looks good here and works, thanks!
| yaml-cpp | ||
| ) | ||
|
|
||
| DEAL_II_SETUP_TARGET(${PROJECT_NAME}) |
There was a problem hiding this comment.
FYI, in CMake, lowercase and uppercase are equivalent.
There was a problem hiding this comment.
FYI, inside the container, this script was not marked as executable.
| @@ -1,7 +1,11 @@ | |||
| #!/usr/bin/env bash | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
The #!/usr/bin/env bash is actually the good practice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My GitLab name is schoenan
Note for building on macOS:
On my macOS (ARM) system, I build the Docker image using:
docker build --platform=linux/amd64 -t cmake-exercise .
I think on a standard x86 Linux system ,
docker build -t cmake-exercise .
would be sufficient.
After building the image, run the container using:
docker run -it cmake-exercise
And build the program using:
./build_and_run.sh